Sent: Friday, May 15, 2015 10:10 AM
To: Nicholas Mc Guire
Cc: Prasad Gondi; linux-s...@vger.kernel.org; James E.J. Bottomley;
linux-kernel@vger.kernel.org; Nicholas Mc Guire; fcoe-de...@open-fcoe.org
Subject: Re: [Open-FCoE] [PATCH] scsi: fix Wunused-but-set-variable buildwarning
On Fri, 2015-0
On Fri, 2015-05-15 at 09:14 +0200, Nicholas Mc Guire wrote:
> On Thu, 14 May 2015, Prasad Gondi wrote:
>
> > It seems like rpriv is used to set the fsp->tgt_flags originally
> >
> > > fsp->tgt_flags = rpriv->flags
> >
> > And fsp->tgt_flags are used in "fc_fcp_cmd_send" like this
> >
> >
On Thu, 14 May 2015, Prasad Gondi wrote:
> It seems like rpriv is used to set the fsp->tgt_flags originally
>
> > fsp->tgt_flags = rpriv->flags
>
> And fsp->tgt_flags are used in "fc_fcp_cmd_send" like this
>
> setup_timer(&fsp->timer, fc_fcp_timeout, (unsigned long)fsp);
>
rg; James E.J. Bottomley;
linux-kernel@vger.kernel.org; linux-s...@vger.kernel.org; Nicholas Mc Guire
Subject: [Open-FCoE] [PATCH] scsi: fix Wunused-but-set-variable buildwarning
commit "[SCSI] libfc: remove tgt_flags from fc_fcp_pkt struct"
removed the last usage of rpriv (rpriv-&
On Thu, 2015-05-14 at 20:12 +0200, Nicholas Mc Guire wrote:
> commit "[SCSI] libfc: remove tgt_flags from fc_fcp_pkt struct"
> removed the last usage of rpriv (rpriv->flags) but forgot to remove
> the unused rpriv struct resulting in:
> drivers/scsi/libfc/fc_fcp.c: In function 'fc_queuecommand':
commit "[SCSI] libfc: remove tgt_flags from fc_fcp_pkt struct"
removed the last usage of rpriv (rpriv->flags) but forgot to remove
the unused rpriv struct resulting in:
drivers/scsi/libfc/fc_fcp.c: In function 'fc_queuecommand':
drivers/scsi/libfc/fc_fcp.c:1795:30: warning: variable 'rpriv' set
6 matches
Mail list logo
