Re: [PATCH] scsi: int overflow in st_ioctl()

2013-12-17 Thread Yu Chen
Because the local variable of st_int_ioctl function, such as long ltmp be assigned by arg. I think we should limit the parameter arg of st_int_ioctl function to the range of 24-bit signed integer. Yong Jianxu, please update your patch. 2013/12/18 "Kai Mäkisara (Kolumbus)" : > On 17.12.2013, at 16

Re: [PATCH] scsi: int overflow in st_ioctl()

2013-12-17 Thread Kai Mäkisara (Kolumbus)
On 17.12.2013, at 16.43, Yongjian Xu xuyongjia...@gmail.com wrote: > From: Yongjian Xu > > mtc.mt_count comes from user-space. > int overflow may occur: > mtc.mt_count++; > mtc.mt_count—; I agree that this is a problem. However, it seems that there is also another problem: the SPACE command us