Re: [PATCH] scsi: libsas and users: Remove notifier indirection

2021-01-12 Thread John Garry
On 12/01/2021 11:25, Ahmed S. Darwish wrote: Since this patch necessitates a careful manual rebase of_every_ patch in my series, I've included it at the top of my v2 submission and rebased everything on top: https://lkml.kernel.org/r/20210112110647.627783-1-a.darw...@linutronix.de Some le

Re: [PATCH] scsi: libsas and users: Remove notifier indirection

2021-01-12 Thread Ahmed S. Darwish
Hi John, On Tue, Jan 12, 2021 at 01:28:32AM +0800, John Garry wrote: > LLDDs report events to libsas with .notify_port_event and > .notify_phy_event callbacks. > > These callbacks are fixed and so there is no reason why the functions > cannot be called directly, so do that. > > This neatens the co

Re: [PATCH] scsi: libsas and users: Remove notifier indirection

2021-01-11 Thread kernel test robot
Hi John, I love your patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on scsi/for-next linus/master v5.11-rc3 next-20210111] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

Re: [PATCH] scsi: libsas and users: Remove notifier indirection

2021-01-11 Thread Ahmed S. Darwish
On Mon, Jan 11, 2021 at 05:44:17PM +, John Garry wrote: > On 11/01/2021 17:41, Ahmed S. Darwish wrote: > > On Tue, Jan 12, 2021 at 01:28:32AM +0800, John Garry wrote: > > ... > > > index a920eced92ec..6a51abdc59ae 100644 > > > --- a/drivers/scsi/mvsas/mv_sas.c > > > +++ b/drivers/scsi/mvsas/mv_

Re: [PATCH] scsi: libsas and users: Remove notifier indirection

2021-01-11 Thread John Garry
On 11/01/2021 17:41, Ahmed S. Darwish wrote: On Tue, Jan 12, 2021 at 01:28:32AM +0800, John Garry wrote: ... index a920eced92ec..6a51abdc59ae 100644 --- a/drivers/scsi/mvsas/mv_sas.c +++ b/drivers/scsi/mvsas/mv_sas.c @@ -230,7 +230,7 @@ static void mvs_bytes_dmaed(struct mvs_info *mvi, int i)

Re: [PATCH] scsi: libsas and users: Remove notifier indirection

2021-01-11 Thread Ahmed S. Darwish
On Tue, Jan 12, 2021 at 01:28:32AM +0800, John Garry wrote: ... > index a920eced92ec..6a51abdc59ae 100644 > --- a/drivers/scsi/mvsas/mv_sas.c > +++ b/drivers/scsi/mvsas/mv_sas.c > @@ -230,7 +230,7 @@ static void mvs_bytes_dmaed(struct mvs_info *mvi, int i) > } > > sas_ha = mvi->sas; > -

[PATCH] scsi: libsas and users: Remove notifier indirection

2021-01-11 Thread John Garry
LLDDs report events to libsas with .notify_port_event and .notify_phy_event callbacks. These callbacks are fixed and so there is no reason why the functions cannot be called directly, so do that. This neatens the code slightly, makes it more obvious, and reduces function pointer usage, which is g