Re: [PATCH] scsi: megaraid: Remove unnecessary assignment to variable ret

2020-08-25 Thread Joe Perches
On Tue, 2020-08-25 at 00:01 -0700, Joe Perches wrote: > On Tue, 2020-08-25 at 14:38 +0800, Jing Xiangfeng wrote: > > The variable ret is being initialized with 'FAILED'. So we can remove > > this assignement. > > If you are going to change the code at all, > might as well try to improve it more by

Re: [PATCH] scsi: megaraid: Remove unnecessary assignment to variable ret

2020-08-25 Thread Joe Perches
On Tue, 2020-08-25 at 14:38 +0800, Jing Xiangfeng wrote: > The variable ret is being initialized with 'FAILED'. So we can remove > this assignement. If you are going to change the code at all, might as well try to improve it more by removing the unnecessary out: label altogether. Perhaps: --- dr

[PATCH] scsi: megaraid: Remove unnecessary assignment to variable ret

2020-08-24 Thread Jing Xiangfeng
The variable ret is being initialized with 'FAILED'. So we can remove this assignement. Signed-off-by: Jing Xiangfeng --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid