Re: [PATCH] scsi: pm8001: pm8001_hwi.c: Fix for possible null pointer dereference

2014-05-29 Thread Rickard Strandqvist
Hi Quite rightly, this is what cppcheck reacts. Ok, I'll send a patch for that instead then. Best regards Rickard Strandqvist 2014-05-28 13:38 GMT+02:00 Tomas Henzl : > On 05/28/2014 01:28 PM, Christoph Hellwig wrote: >> On Sun, May 18, 2014 at 06:14:00PM +0200, Rickard Strandqvist wrote: >>>

Re: [PATCH] scsi: pm8001: pm8001_hwi.c: Fix for possible null pointer dereference

2014-05-28 Thread Tomas Henzl
On 05/28/2014 01:28 PM, Christoph Hellwig wrote: > On Sun, May 18, 2014 at 06:14:00PM +0200, Rickard Strandqvist wrote: >> There is otherwise a risk of a possible null pointer dereference. >> >> Was largely found by using a static code analysis program called cppcheck. > I can't see how dev->lldd_d

Re: [PATCH] scsi: pm8001: pm8001_hwi.c: Fix for possible null pointer dereference

2014-05-28 Thread Christoph Hellwig
On Sun, May 18, 2014 at 06:14:00PM +0200, Rickard Strandqvist wrote: > There is otherwise a risk of a possible null pointer dereference. > > Was largely found by using a static code analysis program called cppcheck. I can't see how dev->lldd_dev would be NULL here. -- To unsubscribe from this lis

[PATCH] scsi: pm8001: pm8001_hwi.c: Fix for possible null pointer dereference

2014-05-18 Thread Rickard Strandqvist
There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/scsi/pm8001/pm8001_hwi.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/s