On Thu, Jun 26, 2014 at 1:50 PM, Maurizio Lombardi wrote:
> On 06/26/2014 10:09 AM, Jack Wang wrote:
>> Thanks Rickard,
>>
>> From my point of view, looks good, but I'd like to get review from Anand
>> (cc-ed).
>
> I would like to add that I noticed that this fields is only set and appears
>
On Thu, Jun 26, 2014 at 1:50 PM, Maurizio Lombardi mlomb...@redhat.com wrote:
On 06/26/2014 10:09 AM, Jack Wang wrote:
Thanks Rickard,
From my point of view, looks good, but I'd like to get review from Anand
(cc-ed).
I would like to add that I noticed that this fields is only set and
On 06/26/2014 10:09 AM, Jack Wang wrote:
> Thanks Rickard,
>
> From my point of view, looks good, but I'd like to get review from Anand
> (cc-ed).
I would like to add that I noticed that this fields is only set and appears to
be never used,
maybe it could be completely removed.
Regards,
Thanks Rickard,
>From my point of view, looks good, but I'd like to get review from Anand
(cc-ed).
Anand, could you share your opinion?
Regards,
Jack
On 06/25/2014 04:01 PM, Rickard Strandqvist wrote:
> A struct member variable is set to different values without having used in
> between.
>
>
Thanks Rickard,
From my point of view, looks good, but I'd like to get review from Anand
(cc-ed).
Anand, could you share your opinion?
Regards,
Jack
On 06/25/2014 04:01 PM, Rickard Strandqvist wrote:
A struct member variable is set to different values without having used in
between.
This
On 06/26/2014 10:09 AM, Jack Wang wrote:
Thanks Rickard,
From my point of view, looks good, but I'd like to get review from Anand
(cc-ed).
I would like to add that I noticed that this fields is only set and appears to
be never used,
maybe it could be completely removed.
Regards,
Maurizio
Hi,
On 06/25/2014 05:41 PM, Purush Gupta wrote:
> Its possible HW may require programming those fields?
I'm looking at the code and it doesn't look so, did you see something
suspicious?
> May be original
> contributor of the driver should review...No offense!
I believe it requires the
This one looks good to me,
Reviewed-by: Maurizio Lombardi
On 06/25/2014 04:01 PM, Rickard Strandqvist wrote:
> A struct member variable is set to different values without having used in
> between.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by:
A struct member variable is set to different values without having used in
between.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/scsi/pm8001/pm80xx_hwi.c |1 -
1 file changed, 1 deletion(-)
diff --git
A struct member variable is set to different values without having used in
between.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
drivers/scsi/pm8001/pm80xx_hwi.c |1 -
1 file changed, 1
This one looks good to me,
Reviewed-by: Maurizio Lombardi mlomb...@redhat.com
On 06/25/2014 04:01 PM, Rickard Strandqvist wrote:
A struct member variable is set to different values without having used in
between.
This was found using a static code analysis program called cppcheck
Hi,
On 06/25/2014 05:41 PM, Purush Gupta wrote:
Its possible HW may require programming those fields?
I'm looking at the code and it doesn't look so, did you see something
suspicious?
May be original
contributor of the driver should review...No offense!
I believe it requires the maintainer
12 matches
Mail list logo
