RE: [EXT] Re: [PATCH] scsi: qedf: Add port_id getter

2019-09-24 Thread Saurav Kashyap
Hi Daniel, > -Original Message- > From: Daniel Wagner > Sent: Tuesday, September 24, 2019 12:54 PM > To: Saurav Kashyap > Cc: qlogic-storage-upstr...@cavium.com; linux-s...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: [EXT] Re: [PATCH] scsi: qed

Re: [PATCH] scsi: qedf: Add port_id getter

2019-09-24 Thread Daniel Wagner
Hi Saurav, On Tue, Sep 24, 2019 at 09:11:38AM +0200, Daniel Wagner wrote: > On Tue, Sep 24, 2019 at 06:08:09AM +, Saurav Kashyap wrote: > > > +static void qedf_get_host_port_id(struct Scsi_Host *shost) { > > > + struct fc_lport *lport = shost_priv(shost); > > > + > > > + fc_host_port_id(shost)

Re: [PATCH] scsi: qedf: Add port_id getter

2019-09-24 Thread Daniel Wagner
On Tue, Sep 24, 2019 at 06:08:09AM +, Saurav Kashyap wrote: > > +static void qedf_get_host_port_id(struct Scsi_Host *shost) { > > + struct fc_lport *lport = shost_priv(shost); > > + > > + fc_host_port_id(shost) = lport->port_id; } > > Minor stuff, the closing brace should be in next line.

RE: [PATCH] scsi: qedf: Add port_id getter

2019-09-23 Thread Saurav Kashyap
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org On > Behalf Of Daniel Wagner > Sent: Monday, September 23, 2019 4:08 PM > To: qlogic-storage-upstr...@cavium.com > Cc: linux-s...@vger.kernel.org; linux-kernel@vger.kernel.org; Daniel Wagner > > Sub

[PATCH] scsi: qedf: Add port_id getter

2019-09-23 Thread Daniel Wagner
Add qedf_get_host_port_id() to the transport template. The fc_transport_template initializes the port_id member to the default value of -1. The new getter ensures that the sysfs entry shows the current value and not the default one, e.g by using 'lsscsi -H -t' Signed-off-by: Daniel Wagner --- d