Re: [PATCH] scsi: qla2xxx: Re-use existing error handling path

2021-04-15 Thread Martin K. Petersen
On Sun, 11 Apr 2021 11:21:40 +0200, Christophe JAILLET wrote: > There is no need to duplicate some code, use the existing error handling > path to free some resources. > This is more future-proof. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: qla2xxx: Re-use existing error handling path

Re: [PATCH] scsi: qla2xxx: Re-use existing error handling path

2021-04-11 Thread Bart Van Assche
On 4/11/21 2:21 AM, Christophe JAILLET wrote: > The code above this hunk looks spurious to me. > > It looks like an error handling path (i.e. > "if (response_len > bsg_job->reply_payload.payload_len)") > but returns 0, which is the initial value of 'ret'. > > Shouldn't we have ret = - here? Hmm

[PATCH] scsi: qla2xxx: Re-use existing error handling path

2021-04-11 Thread Christophe JAILLET
There is no need to duplicate some code, use the existing error handling path to free some resources. This is more future-proof. Signed-off-by: Christophe JAILLET --- The code above this hunk looks spurious to me. It looks like an error handling path (i.e. "if (response_len > bsg_job->reply_payl