Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition

2020-11-30 Thread Daniel Wagner
> >> #define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \ > >> - atomic_dec(&__qpair->ref_count);\ > >> + atomic_dec(&__qpair->ref_count) \ > > Nitpick, please insert an additional tab after the remove so that the > > backlashes align again. > > How about removing the las

Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition

2020-11-30 Thread Tom Rix
On 11/30/20 1:17 AM, Daniel Wagner wrote: > Hi Tom, > > On Fri, Nov 27, 2020 at 10:27:41AM -0800, t...@redhat.com wrote: >> From: Tom Rix >> >> The macro use will already have a semicolon. >> >> Signed-off-by: Tom Rix > Reviewed-by: Daniel Wagner > >> --- >> drivers/scsi/qla2xxx/qla_def.h | 2

Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition

2020-11-30 Thread Daniel Wagner
On Mon, Nov 30, 2020 at 01:29:19AM -0800, Maciej Żenczykowski wrote: > On Mon, Nov 30, 2020 at 1:23 AM Daniel Wagner wrote: > > > #define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \ > > > - atomic_dec(&__qpair->ref_count);\ > > > + atomic_dec(&__qpair->ref_count)

Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition

2020-11-30 Thread Daniel Wagner
Hi Tom, On Fri, Nov 27, 2020 at 10:27:41AM -0800, t...@redhat.com wrote: > From: Tom Rix > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix Reviewed-by: Daniel Wagner > --- > drivers/scsi/qla2xxx/qla_def.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

[PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition

2020-11-27 Thread trix
From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix --- drivers/scsi/qla2xxx/qla_def.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h index ed9b10f8537d..86d249551b2d 100644 --- a