Re: [PATCH] scsi: qla4xxx: remove redundant assignment to variable rval

2020-12-09 Thread Martin K. Petersen
On Fri, 4 Dec 2020 19:18:10 +, Colin King wrote: > The variable rval is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: qla4xxx: remove

Re: [PATCH] scsi: qla4xxx: remove redundant assignment to variable rval

2020-12-07 Thread Martin K. Petersen
Colin, > The variable rval is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

[PATCH] scsi: qla4xxx: remove redundant assignment to variable rval

2020-12-04 Thread Colin King
From: Colin Ian King The variable rval is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/scsi/qla4xxx/ql4_nx.c

Re: [PATCH] scsi: qla4xxx: Remove redundant assignment to variable rval

2020-11-19 Thread Martin K. Petersen
On Tue, 3 Nov 2020 20:01:37 +0800, Jing Xiangfeng wrote: > The variable rval has been initialized with 'QLA_ERROR'. The assignment > is redundant in an error path. So remove it. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: qla4xxx: Remove redundant assignment to variable rval

Re: [PATCH] scsi: qla4xxx: Remove redundant assignment to variable rval

2020-11-16 Thread Martin K. Petersen
Jing, > The variable rval has been initialized with 'QLA_ERROR'. The > assignment is redundant in an error path. So remove it. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

[PATCH] scsi: qla4xxx: Remove redundant assignment to variable rval

2020-11-03 Thread Jing Xiangfeng
The variable rval has been initialized with 'QLA_ERROR'. The assignment is redundant in an error path. So remove it. Signed-off-by: Jing Xiangfeng --- drivers/scsi/qla4xxx/ql4_os.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_os.c