Re: [PATCH] scsi_logging: print cdb into new line after opcode

2021-01-24 Thread Martin Kepplinger
On 23.01.21 04:09, Martin K. Petersen wrote: Ewan, sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28 28 00 00 00 60 40 00 00 01 00 Print the cdb into a new line in any case, not only when cmd_len is greater than 16. The above example error will then read: sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28 28 0

Re: [PATCH] scsi_logging: print cdb into new line after opcode

2021-01-22 Thread Martin K. Petersen
Ewan, >> sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28 28 00 00 00 60 40 00 00 01 >> 00 >> >> Print the cdb into a new line in any case, not only when cmd_len is >> greater than 16. The above example error will then read: >> >> sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28 >> 28 00 01 c0 09 00 00 00 08

Re: [PATCH] scsi_logging: print cdb into new line after opcode

2021-01-22 Thread Ewan D. Milne
On Fri, 2021-01-22 at 09:39 +0100, Martin Kepplinger wrote: > The current log message results in a line like the following where > the first byte is duplicated, giving a wrong impression: > > sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28 28 00 00 00 60 40 00 00 01 > 00 > > Print the cdb into a new lin

[PATCH] scsi_logging: print cdb into new line after opcode

2021-01-22 Thread Martin Kepplinger
The current log message results in a line like the following where the first byte is duplicated, giving a wrong impression: sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28 28 00 00 00 60 40 00 00 01 00 Print the cdb into a new line in any case, not only when cmd_len is greater than 16. The above example