Re: [PATCH] sd: assign appropriate log level

2016-10-17 Thread Daniel Walker
On 10/17/2016 10:19 AM, James Bottomley wrote: On Mon, 2016-10-17 at 09:51 -0700, David Singleton wrote: From: Shikhar Dogra Reduce chatter on console for usb hotplug. KERN_ERR is too high severity for these messages, moving them to KERN_WARNING It's an error because we have several USB to ID

Re: [PATCH] sd: assign appropriate log level

2016-10-17 Thread Joe Perches
On Mon, 2016-10-17 at 09:51 -0700, David Singleton wrote: > From: Shikhar Dogra > > Reduce chatter on console for usb hotplug. > KERN_ERR is too high severity for these messages, moving them > to KERN_WARNING Perhaps KERN_NOTICE is more appropriate. That's the level for most of these sd_first_pr

Re: [PATCH] sd: assign appropriate log level

2016-10-17 Thread James Bottomley
On Mon, 2016-10-17 at 09:51 -0700, David Singleton wrote: > From: Shikhar Dogra > > Reduce chatter on console for usb hotplug. > KERN_ERR is too high severity for these messages, moving them > to KERN_WARNING It's an error because we have several USB to IDE bridges that have write back cache dri

[PATCH] sd: assign appropriate log level

2016-10-17 Thread David Singleton
From: Shikhar Dogra Reduce chatter on console for usb hotplug. KERN_ERR is too high severity for these messages, moving them to KERN_WARNING USB devices never have a Caching Mode page, it doesn't make sense to make it an error when you have tons of USB devices where the print is useless, and not