Re: [PATCH] sdhci: remove redundant check of zero slots

2017-08-18 Thread Adrian Hunter
On 18/08/17 15:37, Colin King wrote: > From: Colin Ian King > > Slots can never be zero, PCI_SLOTS_INFO_SLOTS returns a value in the > range 0..7; slots is one more than this, 1..8 so cannot be zero and > so the zero check is redundant and can be removed. > > Detected

Re: [PATCH] sdhci: remove redundant check of zero slots

2017-08-18 Thread Adrian Hunter
On 18/08/17 15:37, Colin King wrote: > From: Colin Ian King > > Slots can never be zero, PCI_SLOTS_INFO_SLOTS returns a value in the > range 0..7; slots is one more than this, 1..8 so cannot be zero and > so the zero check is redundant and can be removed. > > Detected by CoverityScan,

[PATCH] sdhci: remove redundant check of zero slots

2017-08-18 Thread Colin King
From: Colin Ian King Slots can never be zero, PCI_SLOTS_INFO_SLOTS returns a value in the range 0..7; slots is one more than this, 1..8 so cannot be zero and so the zero check is redundant and can be removed. Detected by CoverityScan, CID#744269 ("Logically Dead Code")

[PATCH] sdhci: remove redundant check of zero slots

2017-08-18 Thread Colin King
From: Colin Ian King Slots can never be zero, PCI_SLOTS_INFO_SLOTS returns a value in the range 0..7; slots is one more than this, 1..8 so cannot be zero and so the zero check is redundant and can be removed. Detected by CoverityScan, CID#744269 ("Logically Dead Code") Signed-off-by: Colin Ian