Re: [PATCH] seccomp: Replace BUG(!spin_is_locked()) with assert_spin_lock

2014-08-11 Thread Kees Cook
On Sun, Aug 10, 2014 at 8:50 PM, Guenter Roeck wrote: > Current upstream kernel hangs with mips and powerpc targets in > uniprocessor mode if SECCOMP is configured. > > Bisect points to commit dbd952127d11 ("seccomp: introduce writer locking"). > Turns out that code such as > BUG_ON(!spin_

Re: [PATCH] seccomp: Replace BUG(!spin_is_locked()) with assert_spin_lock

2014-08-11 Thread Guenter Roeck
On 08/10/2014 11:19 PM, sanjeev sharma wrote: Hello Guenter Roeck The same thing should be taken care in futex.c That is using WARN_ON_SMP which is provided for that purpose. Guenter Regards Sanjeev Sharma On Mon, Aug 11, 2014 at 9:20 AM, Guenter Roeck mailto:li...@roeck-us.net>> wrote:

[PATCH] seccomp: Replace BUG(!spin_is_locked()) with assert_spin_lock

2014-08-10 Thread Guenter Roeck
Current upstream kernel hangs with mips and powerpc targets in uniprocessor mode if SECCOMP is configured. Bisect points to commit dbd952127d11 ("seccomp: introduce writer locking"). Turns out that code such as BUG_ON(!spin_is_locked(&list_lock)); can not be used in uniprocessor mode becau