Re: [PATCH] security: inode: fix a missing check for securityfs_create_file

2019-04-10 Thread James Morris
On Wed, 10 Apr 2019, Al Viro wrote: > Rather bad way to do it - generally, register_filesystem() should be > the last thing done by initialization. Any modular code that > does unregister_filesystem() on failure exit is flat-out broken; > here it's not instantly FUBAR, but it's a bloody bad examp

Re: [PATCH] security: inode: fix a missing check for securityfs_create_file

2019-04-10 Thread Al Viro
On Thu, Apr 11, 2019 at 03:34:43AM +1000, James Morris wrote: > On Fri, 15 Mar 2019, Kangjie Lu wrote: > > > securityfs_create_file may fail. The fix checks its status and > > returns the error code upstream if it fails. > > > > Signed-off-by: Kangjie Lu > > > > Applied to > git://git.kernel.

Re: [PATCH] security: inode: fix a missing check for securityfs_create_file

2019-04-10 Thread James Morris
On Fri, 15 Mar 2019, Kangjie Lu wrote: > securityfs_create_file may fail. The fix checks its status and > returns the error code upstream if it fails. > > Signed-off-by: Kangjie Lu > Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general > --- > Ret

Re: [PATCH] security: inode: fix a missing check for securityfs_create_file

2019-03-15 Thread Tetsuo Handa
On 2019/03/16 6:00, Kangjie Lu wrote: > securityfs_create_file may fail. The fix checks its status and > returns the error code upstream if it fails. Failure in __init functions of vmlinux means that the system failed before the global /sbin/init process starts. There is little value with continu

[PATCH] security: inode: fix a missing check for securityfs_create_file

2019-03-15 Thread Kangjie Lu
securityfs_create_file may fail. The fix checks its status and returns the error code upstream if it fails. Signed-off-by: Kangjie Lu --- Return the exact error code upstream. --- security/inode.c | 5 + 1 file changed, 5 insertions(+) diff --git a/security/inode.c b/security/inode.c inde

Re: [PATCH] security: inode: fix a missing check for securityfs_create_file

2019-03-15 Thread James Morris
On Thu, 14 Mar 2019, Kangjie Lu wrote: > securityfs_create_file may fail. The fix checks its status and > returns EFAULT upstream if it fails. > > Signed-off-by: Kangjie Lu > --- > security/inode.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/security/inode.c b/security/inode

[PATCH] security: inode: fix a missing check for securityfs_create_file

2019-03-14 Thread Kangjie Lu
securityfs_create_file may fail. The fix checks its status and returns EFAULT upstream if it fails. Signed-off-by: Kangjie Lu --- security/inode.c | 5 + 1 file changed, 5 insertions(+) diff --git a/security/inode.c b/security/inode.c index b7772a9b315e..11d9a6bc2161 100644 --- a/security/