Re: [PATCH] security: remove unneeded break

2020-10-26 Thread Jarkko Sakkinen
On Mon, Oct 19, 2020 at 10:36:53AM -0700, t...@redhat.com wrote: > From: Tom Rix > > A break is not needed if it is preceded by a return > > Signed-off-by: Tom Rix Acked-by: Jarkko Sakkinen /Jarkko

Re: [PATCH] security: remove unneeded break

2020-10-20 Thread Mimi Zohar
On Mon, 2020-10-19 at 10:36 -0700, t...@redhat.com wrote: > From: Tom Rix > > A break is not needed if it is preceded by a return > > Signed-off-by: Tom Rix Recently "fall through" comments were added before any case statement without a preceeding break. Have you made sure these changes won't

Re: [PATCH] security: remove unneeded break

2020-10-19 Thread James Morris
On Mon, 19 Oct 2020, t...@redhat.com wrote: > From: Tom Rix > > A break is not needed if it is preceded by a return > > Signed-off-by: Tom Rix Acked-by: James Morris -- James Morris

[PATCH] security: remove unneeded break

2020-10-19 Thread trix
From: Tom Rix A break is not needed if it is preceded by a return Signed-off-by: Tom Rix --- security/integrity/ima/ima_appraise.c | 1 - security/keys/trusted-keys/trusted_tpm1.c | 1 - security/safesetid/lsm.c | 3 --- 3 files changed, 5 deletions(-) diff --git a/securi