Re: [PATCH] seg6: using DSCP of inner IPv4 packets

2020-08-15 Thread Ahmed Abdelsalam
Hi David, Sorry for the late reply. I'm on PTO with limited email access. I will revise the patch in the next weeks and make outer IPv6 header inherit Hop limit from Inner packet for the IPv6 case. Ahmed On 08/08/2020 02:43, David Miller wrote: From: Ahmed Abdelsalam Date: Thu, 6 Aug 2020

Re: [PATCH] seg6: using DSCP of inner IPv4 packets

2020-08-07 Thread David Miller
From: Ahmed Abdelsalam Date: Thu, 6 Aug 2020 08:43:06 +0200 > SRv6 as defined in [1][2] does not mandate that the hop_limit of the > outer IPv6 header has to be copied from the inner packet. This is not an issue of seg6 RFCs, but rather generic ip6 in ip6 tunnel encapsulation. Therefore, what t

Re: [PATCH] seg6: using DSCP of inner IPv4 packets

2020-08-05 Thread Ahmed Abdelsalam
Hi David, SRv6 as defined in [1][2] does not mandate that the hop_limit of the outer IPv6 header has to be copied from the inner packet. The only thing that is mandatory is that the hop_limit of the inner packet has to be decremented [3]. This complies with the specification defined in the G

Re: [PATCH] seg6: using DSCP of inner IPv4 packets

2020-08-05 Thread David Miller
From: Ahmed Abdelsalam Date: Tue, 4 Aug 2020 07:40:30 + > This patch allows copying the DSCP from inner IPv4 header to the > outer IPv6 header, when doing SRv6 Encapsulation. > > This allows forwarding packet across the SRv6 fabric based on their > original traffic class. > > Signed-off-by

Re: [PATCH] seg6: using DSCP of inner IPv4 packets

2020-08-04 Thread David Miller
From: Ahmed Abdelsalam Date: Tue, 4 Aug 2020 07:40:30 + > This patch allows copying the DSCP from inner IPv4 header to the > outer IPv6 header, when doing SRv6 Encapsulation. > > This allows forwarding packet across the SRv6 fabric based on their > original traffic class. > > Signed-off-by

[PATCH] seg6: using DSCP of inner IPv4 packets

2020-08-04 Thread Ahmed Abdelsalam
This patch allows copying the DSCP from inner IPv4 header to the outer IPv6 header, when doing SRv6 Encapsulation. This allows forwarding packet across the SRv6 fabric based on their original traffic class. Signed-off-by: Ahmed Abdelsalam --- net/ipv6/seg6_iptunnel.c | 36 ++