Re: [PATCH] selftests/timers: Add missing error code assignment before test

2016-08-17 Thread John Stultz
On Tue, Aug 9, 2016 at 3:11 AM, Christophe JAILLET wrote: > In order to work, the 'err' return value has to be updated otherwise the > test can never be true. > > Signed-off-by: Christophe JAILLET Acked-by: John Stultz thanks -john

Re: [PATCH] selftests/timers: Add missing error code assignment before test

2016-08-09 Thread walter harms
The patch looks ok. but perhaps it is better to replace this with clock_gettime() ? from the manpage: "POSIX.1-2008 marks gettimeofday() as obsolete, recommending the use of clock_gettime(2) instead." just my 2 cents. re, wh Am 09.08.2016 12:11, schrieb Christophe JAILLET: > In order to wor

[PATCH] selftests/timers: Add missing error code assignment before test

2016-08-09 Thread Christophe JAILLET
In order to work, the 'err' return value has to be updated otherwise the test can never be true. Signed-off-by: Christophe JAILLET --- tools/testing/selftests/timers/posix_timers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/timers/posix_timers