Re: [PATCH] selftests: net: ip_defrag: modprobe missing nf_defrag_ipv6 support

2020-07-16 Thread Paolo Pisati
On Thu, Jul 16, 2020 at 5:38 PM Jakub Kicinski wrote: > > I don't think modprobe fails when code is built in. > > $ sudo modprobe pstore > $ echo $? > 0 > $ grep CONFIG_PSTORE= /boot/config-5.7.8-200.fc32.x86_64 > CONFIG_PSTORE=y > $ lsmod | grep pstore > $ Ah, i didn't know - i'll send a V2

Re: [PATCH] selftests: net: ip_defrag: modprobe missing nf_defrag_ipv6 support

2020-07-16 Thread Jakub Kicinski
On Thu, 16 Jul 2020 09:23:12 +0200 Paolo Pisati wrote: > On Thu, Jul 16, 2020 at 3:01 AM Jakub Kicinski wrote: > > > > Any reason you add this command before set -e ? > > > > It seems we want the script to fail if module can't be loaded. > > Cause if CONFIG_NF_DEFRAG_IPV6=y, the script would

Re: [PATCH] selftests: net: ip_defrag: modprobe missing nf_defrag_ipv6 support

2020-07-16 Thread Paolo Pisati
On Thu, Jul 16, 2020 at 3:01 AM Jakub Kicinski wrote: > > Any reason you add this command before set -e ? > > It seems we want the script to fail if module can't be loaded. Cause if CONFIG_NF_DEFRAG_IPV6=y, the script would unnecessarily fail. -- bye, p.

Re: [PATCH] selftests: net: ip_defrag: modprobe missing nf_defrag_ipv6 support

2020-07-15 Thread Jakub Kicinski
On Tue, 14 Jul 2020 14:40:32 +0200 Paolo Pisati wrote: > # > # Run a couple of IP defragmentation tests. > > +modprobe -q nf_defrag_ipv6 > + > set +x > set -e > Any reason you add this command before set -e ? It seems we want the script to fail if module can't be loaded.

[PATCH] selftests: net: ip_defrag: modprobe missing nf_defrag_ipv6 support

2020-07-14 Thread Paolo Pisati
Fix ip_defrag.sh when CONFIG_NF_DEFRAG_IPV6=m: $ sudo ./ip_defrag.sh + set -e + mktemp -u XX + readonly NETNS=ns-rGlXcw + trap cleanup EXIT + setup + ip netns add ns-rGlXcw + ip -netns ns-rGlXcw link set lo up + ip netns exec ns-rGlXcw sysctl -w net.ipv4.ipfrag_high_thresh=900 + ip netns