Re: [PATCH] semaphore: Resolve some shadow warnings

2014-09-03 Thread Peter Zijlstra
On Tue, Sep 02, 2014 at 09:16:23PM +, Rustad, Mark D wrote: > > It would, but then it would be unclear as to what units the timeout > was in. I have no other objection to timeout, I was just trying to > preserve the meaning in the existing overloaded name. The "n" to me > suggests a number and

Re: [PATCH] semaphore: Resolve some shadow warnings

2014-09-02 Thread Rustad, Mark D
On Sep 1, 2014, at 4:41 PM, Jeff Kirsher wrote: > On Mon, 2014-09-01 at 14:02 +0200, Peter Zijlstra wrote: >> On Thu, Aug 28, 2014 at 05:19:26AM -0700, Jeff Kirsher wrote: >>> From: Mark Rustad >>> >>> Resolve some shadow warnings resulting from using the name >>> jiffies, which is a well-known

Re: [PATCH] semaphore: Resolve some shadow warnings

2014-09-01 Thread Jeff Kirsher
On Mon, 2014-09-01 at 14:02 +0200, Peter Zijlstra wrote: > On Thu, Aug 28, 2014 at 05:19:26AM -0700, Jeff Kirsher wrote: > > From: Mark Rustad > > > > Resolve some shadow warnings resulting from using the name > > jiffies, which is a well-known global. This is not a problem > > of course, but it

Re: [PATCH] semaphore: Resolve some shadow warnings

2014-09-01 Thread Peter Zijlstra
On Thu, Aug 28, 2014 at 05:19:26AM -0700, Jeff Kirsher wrote: > From: Mark Rustad > > Resolve some shadow warnings resulting from using the name > jiffies, which is a well-known global. This is not a problem > of course, but it could be a trap for someone copying and > pasting code, and it just m

[PATCH] semaphore: Resolve some shadow warnings

2014-08-28 Thread Jeff Kirsher
From: Mark Rustad Resolve some shadow warnings resulting from using the name jiffies, which is a well-known global. This is not a problem of course, but it could be a trap for someone copying and pasting code, and it just makes W=2 a little cleaner. Signed-off-by: Mark Rustad Signed-off-by: Jef