Re: [PATCH] serial: 8250: probe all 16550A variants by default

2020-05-26 Thread Josh Triplett
On Tue, May 26, 2020 at 10:05:25AM +0300, Maxim Kochetkov wrote: > This change breaks all my devices: OMAP-L138 (davinci based), LS1021A, > T1040, Marvell (kirkwood2 based). Only enabling VARIANTS on all my devices > fix the issue. Preparing a patch right now, with the appropriate Fixes tag so it

Re: [PATCH] serial: 8250: probe all 16550A variants by default

2020-05-26 Thread Maxim Kochetkov
This change breaks all my devices: OMAP-L138 (davinci based), LS1021A, T1040, Marvell (kirkwood2 based). Only enabling VARIANTS on all my devices fix the issue. 25.05.2020 20:28, Josh Triplett wrote: On Mon, May 25, 2020 at 04:02:38PM +0300, Vladimir Oltean wrote: On NXP T1040, the UART is

Re: [PATCH] serial: 8250: probe all 16550A variants by default

2020-05-25 Thread Josh Triplett
On Mon, May 25, 2020 at 09:52:54PM +0300, Vladimir Oltean wrote: > Hi Josh, > > On Mon, 25 May 2020 at 20:28, Josh Triplett wrote: > > > > On Mon, May 25, 2020 at 04:02:38PM +0300, Vladimir Oltean wrote: > > > On NXP T1040, the UART is typically detected as 16550A_FSL64. After said > > > patch,

Re: [PATCH] serial: 8250: probe all 16550A variants by default

2020-05-25 Thread Vladimir Oltean
Hi Josh, On Mon, 25 May 2020 at 20:28, Josh Triplett wrote: > > On Mon, May 25, 2020 at 04:02:38PM +0300, Vladimir Oltean wrote: > > On NXP T1040, the UART is typically detected as 16550A_FSL64. After said > > patch, it gets detected as plain 16550A and the Linux console is > > completely

Re: [PATCH] serial: 8250: probe all 16550A variants by default

2020-05-25 Thread Josh Triplett
On Mon, May 25, 2020 at 04:02:38PM +0300, Vladimir Oltean wrote: > On NXP T1040, the UART is typically detected as 16550A_FSL64. After said > patch, it gets detected as plain 16550A and the Linux console is > completely garbled and missing characters. Interesting that there's *new* powerpc

Re: [PATCH] serial: 8250: probe all 16550A variants by default

2020-05-25 Thread Andy Shevchenko
On Mon, May 25, 2020 at 04:02:38PM +0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > On NXP T1040, the UART is typically detected as 16550A_FSL64. After said > patch, it gets detected as plain 16550A and the Linux console is > completely garbled and missing characters. > > So clearly,

[PATCH] serial: 8250: probe all 16550A variants by default

2020-05-25 Thread Vladimir Oltean
From: Vladimir Oltean On NXP T1040, the UART is typically detected as 16550A_FSL64. After said patch, it gets detected as plain 16550A and the Linux console is completely garbled and missing characters. So clearly, introducing the SERIAL_8250_16550A_VARIANTS config option has broken many