Re: [PATCH] serial: 8250_dw: Minor code cleanup

2017-03-29 Thread Doug Anderson
Hi, On Wed, Mar 29, 2017 at 10:10 AM, Olliver Schinagl wrote: > Hey Doug, > > On 29-03-17 17:50, Doug Anderson wrote: >> >> Hi, >> >> On Wed, Mar 29, 2017 at 3:04 AM, Olliver Schinagl >> wrote: >>> >>> Commit 424d79183af0 ("serial: 8250_dw: Avoid

Re: [PATCH] serial: 8250_dw: Minor code cleanup

2017-03-29 Thread Doug Anderson
Hi, On Wed, Mar 29, 2017 at 10:10 AM, Olliver Schinagl wrote: > Hey Doug, > > On 29-03-17 17:50, Doug Anderson wrote: >> >> Hi, >> >> On Wed, Mar 29, 2017 at 3:04 AM, Olliver Schinagl >> wrote: >>> >>> Commit 424d79183af0 ("serial: 8250_dw: Avoid "too much work" from bogus >>> rx timeout

Re: [PATCH] serial: 8250_dw: Minor code cleanup

2017-03-29 Thread Olliver Schinagl
Hey Doug, On 29-03-17 19:10, Olliver Schinagl wrote: Hey Doug, On 29-03-17 17:50, Doug Anderson wrote: Hi, On Wed, Mar 29, 2017 at 3:04 AM, Olliver Schinagl wrote: Commit 424d79183af0 ("serial: 8250_dw: Avoid "too much work" from bogus rx timeout interrupt") added a bit

Re: [PATCH] serial: 8250_dw: Minor code cleanup

2017-03-29 Thread Olliver Schinagl
Hey Doug, On 29-03-17 19:10, Olliver Schinagl wrote: Hey Doug, On 29-03-17 17:50, Doug Anderson wrote: Hi, On Wed, Mar 29, 2017 at 3:04 AM, Olliver Schinagl wrote: Commit 424d79183af0 ("serial: 8250_dw: Avoid "too much work" from bogus rx timeout interrupt") added a bit check with quite a

Re: [PATCH] serial: 8250_dw: Minor code cleanup

2017-03-29 Thread Olliver Schinagl
Hey Doug, On 29-03-17 17:50, Doug Anderson wrote: Hi, On Wed, Mar 29, 2017 at 3:04 AM, Olliver Schinagl wrote: Commit 424d79183af0 ("serial: 8250_dw: Avoid "too much work" from bogus rx timeout interrupt") added a bit check with quite a wide mask. To be concise with the

Re: [PATCH] serial: 8250_dw: Minor code cleanup

2017-03-29 Thread Olliver Schinagl
Hey Doug, On 29-03-17 17:50, Doug Anderson wrote: Hi, On Wed, Mar 29, 2017 at 3:04 AM, Olliver Schinagl wrote: Commit 424d79183af0 ("serial: 8250_dw: Avoid "too much work" from bogus rx timeout interrupt") added a bit check with quite a wide mask. To be concise with the other similar calls

Re: [PATCH] serial: 8250_dw: Minor code cleanup

2017-03-29 Thread Doug Anderson
Hi, On Wed, Mar 29, 2017 at 3:04 AM, Olliver Schinagl wrote: > Commit 424d79183af0 ("serial: 8250_dw: Avoid "too much work" from bogus rx > timeout interrupt") > added a bit check with quite a wide mask. To be concise with the other > similar calls in this driver, change it

Re: [PATCH] serial: 8250_dw: Minor code cleanup

2017-03-29 Thread Doug Anderson
Hi, On Wed, Mar 29, 2017 at 3:04 AM, Olliver Schinagl wrote: > Commit 424d79183af0 ("serial: 8250_dw: Avoid "too much work" from bogus rx > timeout interrupt") > added a bit check with quite a wide mask. To be concise with the other > similar calls in this driver, change it to mask against the

[PATCH] serial: 8250_dw: Minor code cleanup

2017-03-29 Thread Olliver Schinagl
Commit 424d79183af0 ("serial: 8250_dw: Avoid "too much work" from bogus rx timeout interrupt") added a bit check with quite a wide mask. To be concise with the other similar calls in this driver, change it to mask against the flag we want to check only. This thus removes a magic value/mask. Some

[PATCH] serial: 8250_dw: Minor code cleanup

2017-03-29 Thread Olliver Schinagl
Commit 424d79183af0 ("serial: 8250_dw: Avoid "too much work" from bogus rx timeout interrupt") added a bit check with quite a wide mask. To be concise with the other similar calls in this driver, change it to mask against the flag we want to check only. This thus removes a magic value/mask. Some