Re: [PATCH] serial: 8250_fintek: fix the mismatched IRQ mode

2016-06-27 Thread Ji-Ze Hong (Peter Hong)
Hi Ricardo & Greg, Ricardo Ribalda Delgado 於 2016/6/27 下午 06:25 寫道: Hi Peter,. Hi Greg On Fri, May 27, 2016 at 4:02 AM, Ji-Ze Hong (Peter Hong) + struct irq_data *irq_data = irq_get_irq_data(uart->port.irq); + bool level_mode = irqd_is_level_type(irq_data); I see a potential probl

Re: [PATCH] serial: 8250_fintek: fix the mismatched IRQ mode

2016-06-27 Thread Ricardo Ribalda Delgado
Hi Peter,. Hi Greg On Fri, May 27, 2016 at 4:02 AM, Ji-Ze Hong (Peter Hong) wrote: > { > struct fintek_8250 *pdata; > struct fintek_8250 probe_data; > + struct irq_data *irq_data = irq_get_irq_data(uart->port.irq); > + bool level_mode = irqd_is_level_type(irq_data);

[PATCH] serial: 8250_fintek: fix the mismatched IRQ mode

2016-05-26 Thread Ji-Ze Hong (Peter Hong)
Some BIOS only use _OSI("Linux") to distinguish between Linux & Windows. Apply Level/Low to UART trigger mode if Windows, Edge/High mode otherwise. But since 2.6.23 the mainline kernel no longer returns true for _OSI(“Linux”). The default IRQ0~15 trigger mode in Linux is Edge/High mode without ACP