Re: [PATCH] serial: 8250_lpss: Release Quark MSI vectors on exit

2017-01-08 Thread Andy Shevchenko
On Sun, 2017-01-08 at 02:24 -0800, Christoph Hellwig wrote: > On Thu, Jan 05, 2017 at 12:19:56AM +0200, Andy Shevchenko wrote: > > NAK, check the PCI devres code, please. +Cc: Tejun, Bjorn. > > Releasing something through devres that wasn't allocated using a > devm_* or > pcim_* function isn't e

Re: [PATCH] serial: 8250_lpss: Release Quark MSI vectors on exit

2017-01-08 Thread Christoph Hellwig
On Thu, Jan 05, 2017 at 12:19:56AM +0200, Andy Shevchenko wrote: > NAK, check the PCI devres code, please. Releasing something through devres that wasn't allocated using a devm_* or pcim_* function isn't expected, and we should fix that instead. pci_free_irq_vectors is _currently_ implemented by c

Re: [PATCH] serial: 8250_lpss: Release Quark MSI vectors on exit

2017-01-05 Thread Andy Shevchenko
On Wed, 2017-01-04 at 21:25 -0800, Christoph Hellwig wrote: > On Wed, Jan 04, 2017 at 08:36:51PM +0100, Jan Kiszka wrote: > > No one seems to do this magically in the background, so we have to > > do > > the job in the exit handler that corresponds to the board setup > > handler. > > > > Fixes: 60

Re: [PATCH] serial: 8250_lpss: Release Quark MSI vectors on exit

2017-01-04 Thread Jan Kiszka
On 2017-01-05 06:25, Christoph Hellwig wrote: > On Wed, Jan 04, 2017 at 11:46:58PM +0100, Jan Kiszka wrote: >>> I NAKed already third patch related to PCI managed resources (couple >>> of those regarding to pci_irq_* API)/ >>> >> >> Ah, there are resources that are managed without being allocated >

Re: [PATCH] serial: 8250_lpss: Release Quark MSI vectors on exit

2017-01-04 Thread Christoph Hellwig
On Wed, Jan 04, 2017 at 11:46:58PM +0100, Jan Kiszka wrote: > > I NAKed already third patch related to PCI managed resources (couple > > of those regarding to pci_irq_* API)/ > > > > Ah, there are resources that are managed without being allocated > explicitly that way. Hmm, not very intuitive. A

Re: [PATCH] serial: 8250_lpss: Release Quark MSI vectors on exit

2017-01-04 Thread Christoph Hellwig
On Wed, Jan 04, 2017 at 08:36:51PM +0100, Jan Kiszka wrote: > No one seems to do this magically in the background, so we have to do > the job in the exit handler that corresponds to the board setup handler. > > Fixes: 60a9244a5d14 ("serial: 8250_lpss: enable MSI for Intel Quark") > Signed-off-by:

Re: [PATCH] serial: 8250_lpss: Release Quark MSI vectors on exit

2017-01-04 Thread Andy Shevchenko
On Thu, Jan 5, 2017 at 12:46 AM, Jan Kiszka wrote: > On 2017-01-04 23:19, Andy Shevchenko wrote: >> On Wed, Jan 4, 2017 at 9:36 PM, Jan Kiszka wrote: >>> No one seems to do this magically in the background, so we have to do >>> the job in the exit handler that corresponds to the board setup handl

Re: [PATCH] serial: 8250_lpss: Release Quark MSI vectors on exit

2017-01-04 Thread Jan Kiszka
On 2017-01-04 23:19, Andy Shevchenko wrote: > On Wed, Jan 4, 2017 at 9:36 PM, Jan Kiszka wrote: >> No one seems to do this magically in the background, so we have to do >> the job in the exit handler that corresponds to the board setup handler. >> >> Fixes: 60a9244a5d14 ("serial: 8250_lpss: enable

Re: [PATCH] serial: 8250_lpss: Release Quark MSI vectors on exit

2017-01-04 Thread Andy Shevchenko
On Wed, Jan 4, 2017 at 9:36 PM, Jan Kiszka wrote: > No one seems to do this magically in the background, so we have to do > the job in the exit handler that corresponds to the board setup handler. > > Fixes: 60a9244a5d14 ("serial: 8250_lpss: enable MSI for Intel Quark") > Signed-off-by: Jan Kiszka

[PATCH] serial: 8250_lpss: Release Quark MSI vectors on exit

2017-01-04 Thread Jan Kiszka
No one seems to do this magically in the background, so we have to do the job in the exit handler that corresponds to the board setup handler. Fixes: 60a9244a5d14 ("serial: 8250_lpss: enable MSI for Intel Quark") Signed-off-by: Jan Kiszka --- drivers/tty/serial/8250/8250_lpss.c | 9 + 1