Re: [PATCH] serial: 8250_port: Fix imprecise external abort for mctrl if inactive

2020-06-15 Thread Andy Shevchenko
On Tue, Jun 02, 2020 at 11:55:15AM -0700, Tony Lindgren wrote: > * Tony Lindgren [200602 13:38]: > > * Andy Shevchenko [200602 08:33]: > > Now that we can detach and reattach the kernel serial console, > > there should not be any need for pm_runtime_irq_safe() anymore :) > > Below is a hastily

Re: [PATCH] serial: 8250_port: Fix imprecise external abort for mctrl if inactive

2020-06-02 Thread Tony Lindgren
* Tony Lindgren [200602 13:38]: > * Andy Shevchenko [200602 08:33]: > Now that we can detach and reattach the kernel serial console, > there should not be any need for pm_runtime_irq_safe() anymore :) Below is a hastily tested RFC patch to remove pm_runtime_irq_safe() for 8250_omap.c that seems

Re: [PATCH] serial: 8250_port: Fix imprecise external abort for mctrl if inactive

2020-06-02 Thread Tony Lindgren
* Andy Shevchenko [200602 08:33]: > On Tue, Jun 2, 2020 at 11:09 AM Johan Hovold wrote: > > On Mon, Jun 01, 2020 at 05:18:13PM -0700, Tony Lindgren wrote: > > ... > > > There's shouldn't be anything fundamental preventing you from adding the > > missing resume calls to the mctrl paths even if

Re: [PATCH] serial: 8250_port: Fix imprecise external abort for mctrl if inactive

2020-06-02 Thread Andy Shevchenko
On Tue, Jun 2, 2020 at 11:09 AM Johan Hovold wrote: > On Mon, Jun 01, 2020 at 05:18:13PM -0700, Tony Lindgren wrote: ... > There's shouldn't be anything fundamental preventing you from adding the > missing resume calls to the mctrl paths even if it may require reworking > (and fixing) the whole

Re: [PATCH] serial: 8250_port: Fix imprecise external abort for mctrl if inactive

2020-06-02 Thread Johan Hovold
On Mon, Jun 01, 2020 at 05:18:13PM -0700, Tony Lindgren wrote: > We can get an imprecise external abort on uart_shutdown() at > serial8250_do_set_mctrl() if the UART is autoidled. > > We don't want to add PM runtime calls to serial8250_do_set_mctrl() > beyond checking the usage count as it gets

[PATCH] serial: 8250_port: Fix imprecise external abort for mctrl if inactive

2020-06-01 Thread Tony Lindgren
We can get an imprecise external abort on uart_shutdown() at serial8250_do_set_mctrl() if the UART is autoidled. We don't want to add PM runtime calls to serial8250_do_set_mctrl() beyond checking the usage count as it gets called from interrupts disabled and spinlock held from