Hi Masahiro,
Apologies for the delay in reply; I didn't see the lower part of your email.
On 10/28/2015 09:49 PM, Masahiro Yamada wrote:
>>> +#if IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE)
>>
>> #ifdef CONFIG_SERIAL_8250_CONSOLE
>
> I am OK with this change because this CONFIG is boolean.
>
>
>
Hi Masahiro,
Apologies for the delay in reply; I didn't see the lower part of your email.
On 10/28/2015 09:49 PM, Masahiro Yamada wrote:
>>> +#if IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE)
>>
>> #ifdef CONFIG_SERIAL_8250_CONSOLE
>
> I am OK with this change because this CONFIG is boolean.
>
>
>
Hi Peter,
>>
>> +#if IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE)
>
> #ifdef CONFIG_SERIAL_8250_CONSOLE
I am OK with this change because this CONFIG is boolean.
I still believe
#if IS_ENABLED(CONFIG_FOO)
is a nice shorthand for
#if defined(CONFIG_FOO) || defined(CONFIG_FOO_MODULE)
when
Hi Masahiro,
On 10/22/2015 04:39 AM, Masahiro Yamada wrote:
> This reuses the code of drivers/tty/serial/8250/8250_early.c except
>
> - Overwrite device->port.iotype and device->port.regshift for
> UPIO_MEM32 because of_setup_earlycon() has set them for UPIO_MEM.
>
> - Set device->baud
Hi Masahiro,
On 10/22/2015 04:39 AM, Masahiro Yamada wrote:
> This reuses the code of drivers/tty/serial/8250/8250_early.c except
>
> - Overwrite device->port.iotype and device->port.regshift for
> UPIO_MEM32 because of_setup_earlycon() has set them for UPIO_MEM.
>
> - Set device->baud
Hi Peter,
>>
>> +#if IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE)
>
> #ifdef CONFIG_SERIAL_8250_CONSOLE
I am OK with this change because this CONFIG is boolean.
I still believe
#if IS_ENABLED(CONFIG_FOO)
is a nice shorthand for
#if defined(CONFIG_FOO) || defined(CONFIG_FOO_MODULE)
when
This reuses the code of drivers/tty/serial/8250/8250_early.c except
- Overwrite device->port.iotype and device->port.regshift for
UPIO_MEM32 because of_setup_earlycon() has set them for UPIO_MEM.
- Set device->baud to zero to prevent early8250_setup() from
initializing the divisor
This reuses the code of drivers/tty/serial/8250/8250_early.c except
- Overwrite device->port.iotype and device->port.regshift for
UPIO_MEM32 because of_setup_earlycon() has set them for UPIO_MEM.
- Set device->baud to zero to prevent early8250_setup() from
initializing the divisor
8 matches
Mail list logo