Re: [PATCH] serial: 8250_uniphier: add earlycon support

2015-11-05 Thread Peter Hurley
Hi Masahiro, Apologies for the delay in reply; I didn't see the lower part of your email. On 10/28/2015 09:49 PM, Masahiro Yamada wrote: >>> +#if IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE) >> >> #ifdef CONFIG_SERIAL_8250_CONSOLE > > I am OK with this change because this CONFIG is boolean. > > >

Re: [PATCH] serial: 8250_uniphier: add earlycon support

2015-11-05 Thread Peter Hurley
Hi Masahiro, Apologies for the delay in reply; I didn't see the lower part of your email. On 10/28/2015 09:49 PM, Masahiro Yamada wrote: >>> +#if IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE) >> >> #ifdef CONFIG_SERIAL_8250_CONSOLE > > I am OK with this change because this CONFIG is boolean. > > >

Re: [PATCH] serial: 8250_uniphier: add earlycon support

2015-10-28 Thread Masahiro Yamada
Hi Peter, >> >> +#if IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE) > > #ifdef CONFIG_SERIAL_8250_CONSOLE I am OK with this change because this CONFIG is boolean. I still believe #if IS_ENABLED(CONFIG_FOO) is a nice shorthand for #if defined(CONFIG_FOO) || defined(CONFIG_FOO_MODULE) when

Re: [PATCH] serial: 8250_uniphier: add earlycon support

2015-10-28 Thread Peter Hurley
Hi Masahiro, On 10/22/2015 04:39 AM, Masahiro Yamada wrote: > This reuses the code of drivers/tty/serial/8250/8250_early.c except > > - Overwrite device->port.iotype and device->port.regshift for > UPIO_MEM32 because of_setup_earlycon() has set them for UPIO_MEM. > > - Set device->baud

Re: [PATCH] serial: 8250_uniphier: add earlycon support

2015-10-28 Thread Peter Hurley
Hi Masahiro, On 10/22/2015 04:39 AM, Masahiro Yamada wrote: > This reuses the code of drivers/tty/serial/8250/8250_early.c except > > - Overwrite device->port.iotype and device->port.regshift for > UPIO_MEM32 because of_setup_earlycon() has set them for UPIO_MEM. > > - Set device->baud

Re: [PATCH] serial: 8250_uniphier: add earlycon support

2015-10-28 Thread Masahiro Yamada
Hi Peter, >> >> +#if IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE) > > #ifdef CONFIG_SERIAL_8250_CONSOLE I am OK with this change because this CONFIG is boolean. I still believe #if IS_ENABLED(CONFIG_FOO) is a nice shorthand for #if defined(CONFIG_FOO) || defined(CONFIG_FOO_MODULE) when

[PATCH] serial: 8250_uniphier: add earlycon support

2015-10-22 Thread Masahiro Yamada
This reuses the code of drivers/tty/serial/8250/8250_early.c except - Overwrite device->port.iotype and device->port.regshift for UPIO_MEM32 because of_setup_earlycon() has set them for UPIO_MEM. - Set device->baud to zero to prevent early8250_setup() from initializing the divisor

[PATCH] serial: 8250_uniphier: add earlycon support

2015-10-22 Thread Masahiro Yamada
This reuses the code of drivers/tty/serial/8250/8250_early.c except - Overwrite device->port.iotype and device->port.regshift for UPIO_MEM32 because of_setup_earlycon() has set them for UPIO_MEM. - Set device->baud to zero to prevent early8250_setup() from initializing the divisor