Re: [PATCH] serial: mps2-uart: Add parentheses around conditional in mps2_uart_shutdown

2019-01-31 Thread Nick Desaulniers
On Thu, Jan 31, 2019 at 10:06 AM Nathan Chancellor wrote: > > Clang warns: > > drivers/tty/serial/mps2-uart.c:351:6: warning: logical not is only > applied to the left hand side of this bitwise operator > [-Wlogical-not-parentheses] > if (!mps_port->flags & UART_PORT_COMBINED_IRQ) { >

Re: [PATCH] serial: mps2-uart: Add parentheses around conditional in mps2_uart_shutdown

2019-01-31 Thread Vladimir Murzin
On 1/31/19 6:06 PM, Nathan Chancellor wrote: > Clang warns: > > drivers/tty/serial/mps2-uart.c:351:6: warning: logical not is only > applied to the left hand side of this bitwise operator > [-Wlogical-not-parentheses] > if (!mps_port->flags & UART_PORT_COMBINED_IRQ) { > ^

[PATCH] serial: mps2-uart: Add parentheses around conditional in mps2_uart_shutdown

2019-01-31 Thread Nathan Chancellor
Clang warns: drivers/tty/serial/mps2-uart.c:351:6: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses] if (!mps_port->flags & UART_PORT_COMBINED_IRQ) { ^~ drivers/tty/serial/mps2-uart.c:351:6: note: add