Re: [PATCH] serial: mvebu-uart: Fix local flags handling on termios update

2018-04-23 Thread Russell King - ARM Linux
On Mon, Apr 23, 2018 at 04:04:06PM +0100, Russell King - ARM Linux wrote: > On Sun, Apr 22, 2018 at 08:58:04PM +0100, Russell King - ARM Linux wrote: > > On Sun, Apr 22, 2018 at 06:07:28PM +0100, Marc Zyngier wrote: > > > On Sun, 22 Apr 2018 16:55:16 +0100 > > > Russell King - ARM Linux wrote: > >

Re: [PATCH] serial: mvebu-uart: Fix local flags handling on termios update

2018-04-23 Thread Russell King - ARM Linux
On Sun, Apr 22, 2018 at 08:58:04PM +0100, Russell King - ARM Linux wrote: > On Sun, Apr 22, 2018 at 06:07:28PM +0100, Marc Zyngier wrote: > > On Sun, 22 Apr 2018 16:55:16 +0100 > > Russell King - ARM Linux wrote: > > > > > On Sun, Apr 22, 2018 at 01:33:46PM +0100, Marc Zyngier wrote: > > > > Comm

Re: [PATCH] serial: mvebu-uart: Fix local flags handling on termios update

2018-04-22 Thread Russell King - ARM Linux
On Sun, Apr 22, 2018 at 06:07:28PM +0100, Marc Zyngier wrote: > On Sun, 22 Apr 2018 16:55:16 +0100 > Russell King - ARM Linux wrote: > > > On Sun, Apr 22, 2018 at 01:33:46PM +0100, Marc Zyngier wrote: > > > Commit 68a0db1d7da2 reworked the baud rate selection, but also added > > > a (not so) subt

Re: [PATCH] serial: mvebu-uart: Fix local flags handling on termios update

2018-04-22 Thread Marc Zyngier
On Sun, 22 Apr 2018 16:55:16 +0100 Russell King - ARM Linux wrote: > On Sun, Apr 22, 2018 at 01:33:46PM +0100, Marc Zyngier wrote: > > Commit 68a0db1d7da2 reworked the baud rate selection, but also added > > a (not so) subtle change in the way the local flags (c_lflag in the > > termios structure

Re: [PATCH] serial: mvebu-uart: Fix local flags handling on termios update

2018-04-22 Thread Russell King - ARM Linux
On Sun, Apr 22, 2018 at 01:33:46PM +0100, Marc Zyngier wrote: > Commit 68a0db1d7da2 reworked the baud rate selection, but also added > a (not so) subtle change in the way the local flags (c_lflag in the > termios structure) are handled, forcing the new flags to always be the > same as the old ones.

[PATCH] serial: mvebu-uart: Fix local flags handling on termios update

2018-04-22 Thread Marc Zyngier
Commit 68a0db1d7da2 reworked the baud rate selection, but also added a (not so) subtle change in the way the local flags (c_lflag in the termios structure) are handled, forcing the new flags to always be the same as the old ones. The reason for that particular change is both obscure and undocument