Hello.
Marc St-Jean wrote:
> diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
> index 3d91bfc..bfaacc5 100644
> --- a/drivers/serial/8250.c
> +++ b/drivers/serial/8250.c
> @@ -308,6 +308,7 @@ static unsigned int serial_in(struct uar
> return inb(up->port.iobase + 1);
>
Sergei Shtylyov wrote:
> Hello.
>
> Marc St-Jean wrote:
>
> > There are three different fixes:
> > 1. Fix for DesignWare APB THRE errata:
> > In brief, this is a non-standard 16550 in that the THRE interrupt
> > will not re-assert itself simply by disabling and re-enabling the
> > THRI
Andrew Morton wrote:
> On Thu, 15 Feb 2007 13:26:29 -0600
> Marc St-Jean <[EMAIL PROTECTED]> wrote:
>
> > + status = *(volatile u32 *)up->port.private_data;
>
> It distresses me that this patch uses a variable which this patch
> doesn't initialise anywhere. It isn't
Andrew Morton wrote:
On Thu, 15 Feb 2007 13:26:29 -0600
Marc St-Jean [EMAIL PROTECTED] wrote:
+ status = *(volatile u32 *)up-port.private_data;
It distresses me that this patch uses a variable which this patch
doesn't initialise anywhere. It isn't complete.
The
Sergei Shtylyov wrote:
Hello.
Marc St-Jean wrote:
There are three different fixes:
1. Fix for DesignWare APB THRE errata:
In brief, this is a non-standard 16550 in that the THRE interrupt
will not re-assert itself simply by disabling and re-enabling the
THRI bit in the IER,
Hello.
Marc St-Jean wrote:
diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index 3d91bfc..bfaacc5 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -308,6 +308,7 @@ static unsigned int serial_in(struct uar
return inb(up-port.iobase + 1);
Andrew Morton wrote:
> On Mon, 12 Feb 2007 12:04:08 -0600 Marc St-Jean
> <[EMAIL PROTECTED]> wrote:
>
> > There are three different fixes:
> > 1. Fix for DesignWare THRE errata
> > - Dropped our fix since the "8250-uart-backup-timer.patch" in the "mm"
> > tree also fixes it. This patch needs
Andrew Morton wrote:
On Mon, 12 Feb 2007 12:04:08 -0600 Marc St-Jean
[EMAIL PROTECTED] wrote:
There are three different fixes:
1. Fix for DesignWare THRE errata
- Dropped our fix since the 8250-uart-backup-timer.patch in the mm
tree also fixes it. This patch needs to be applied on
Hello.
Marc St-Jean wrote:
>> > Fourth attempt at the serial driver patch for the PMC-Sierra MSP71xx
>>device.
I think you need to submit your patch to Andrew Morton since it
requires a patch from his tree.
OK, will do.
In fact, since the serial drivers are not maintained
Sergei Shtylyov wrote:
> Hello.
>
> Marc St-Jean wrote:
>
> >> > Fourth attempt at the serial driver patch for the PMC-Sierra MSP71xx
> >>device.
>
> I think you need to submit your patch to Andrew Morton since it
> requires a patch from his tree.
OK, will do.
> >> > @@ -1383,6
Sergei Shtylyov wrote:
Hello.
Marc St-Jean wrote:
Fourth attempt at the serial driver patch for the PMC-Sierra MSP71xx
device.
I think you need to submit your patch to Andrew Morton since it
requires a patch from his tree.
OK, will do.
@@ -1383,6 +1399,19 @@ static
Hello.
Marc St-Jean wrote:
Fourth attempt at the serial driver patch for the PMC-Sierra MSP71xx
device.
I think you need to submit your patch to Andrew Morton since it
requires a patch from his tree.
OK, will do.
In fact, since the serial drivers are not maintained anymore,
Hello.
Marc St-Jean wrote:
> Fourth attempt at the serial driver patch for the PMC-Sierra MSP71xx
device.
> There are three different fixes:
> 1. Fix for DesignWare THRE errata
> - Dropped our fix since the "8250-uart-backup-timer.patch" in the "mm"
> tree also fixes it. This patch needs to
Hello.
Marc St-Jean wrote:
Fourth attempt at the serial driver patch for the PMC-Sierra MSP71xx
device.
There are three different fixes:
1. Fix for DesignWare THRE errata
- Dropped our fix since the 8250-uart-backup-timer.patch in the mm
tree also fixes it. This patch needs to be
Sergei Shtylyov wrote:
> Marc St-Jean wrote:
> > Fourth attempt at the serial driver patch for the PMC-Sierra MSP71xx
> device.
> >
> > There are three different fixes:
> > 1. Fix for DesignWare THRE errata
> > - Dropped our fix since the "8250-uart-backup-timer.patch" in the "mm"
> > tree
Sergei Shtylyov wrote:
Marc St-Jean wrote:
Fourth attempt at the serial driver patch for the PMC-Sierra MSP71xx
device.
There are three different fixes:
1. Fix for DesignWare THRE errata
- Dropped our fix since the 8250-uart-backup-timer.patch in the mm
tree also fixes it.
Sergei Shtylyov wrote:
> Marc St-Jean wrote:
> > Third attempt at the serial driver patch for the PMC-Sierra MSP71xx
> device.
> >
> > There are three different fixes:
> > 1. Fix for DesignWare THRE errata
> > - Dropped our fix since the "8250-uart-backup-timer.patch" in the "mm"
> > tree
Sergei Shtylyov wrote:
Marc St-Jean wrote:
Third attempt at the serial driver patch for the PMC-Sierra MSP71xx
device.
There are three different fixes:
1. Fix for DesignWare THRE errata
- Dropped our fix since the 8250-uart-backup-timer.patch in the mm
tree also fixes it. This
Thank Alan. I made the changes yesterday but I'll wait another day
before reposting, in case other interested people have more comments.
Marc
Alan wrote:
> > unsigned char hub6; /* this should
> be in the 8250 driver */
> > unsigned char
Thank Alan. I made the changes yesterday but I'll wait another day
before reposting, in case other interested people have more comments.
Marc
Alan wrote:
unsigned char hub6; /* this should
be in the 8250 driver */
unsigned char unused[3];
Sergei Shtylyov wrote:
> Hello.
>
> Marc St-Jean wrote:
>
> >> > Index: linux_2_6/drivers/serial/8250.c
> >> > ===
> >> > RCS file: linux_2_6/drivers/serial/8250.c,v
> >> > retrieving revision 1.1.1.7
> >> > diff -u -r1.1.1.7
Hello.
Marc St-Jean wrote:
> Here is my second attempt at the serial driver patch for the
> PMC-Sierra MSP71xx device.
> There are three different fixes:
> 1. Fix for THRE errata
> - I verified the UART_BUG_TXEN fix does not help with this erratum.
> - I left our current fix in until I get
Hello.
Marc St-Jean wrote:
Here is my second attempt at the serial driver patch for the
PMC-Sierra MSP71xx device.
There are three different fixes:
1. Fix for THRE errata
- I verified the UART_BUG_TXEN fix does not help with this erratum.
- I left our current fix in until I get our
Sergei Shtylyov wrote:
Hello.
Marc St-Jean wrote:
Index: linux_2_6/drivers/serial/8250.c
===
RCS file: linux_2_6/drivers/serial/8250.c,v
retrieving revision 1.1.1.7
diff -u -r1.1.1.7 8250.c
---
Sergei Shtylyov wrote:
> Marc St-Jean wrote:
> > Here is my second attempt at the serial driver patch for the
> > PMC-Sierra MSP71xx device.
> >
> > There are three different fixes:
> > 1. Fix for THRE errata
> > - I verified the UART_BUG_TXEN fix does not help with this erratum.
> > - I
Hello.
Marc St-Jean wrote:
> I could use both iotype and type with a test on each for the appropriate
> bug, what do you recommend?
I think iotype would be enough. You can't pass type for platform
devices anyway, IIRC (the thing I don't quite like).
I just found that out the hard way,
Hello.
Marc St-Jean wrote:
I could use both iotype and type with a test on each for the appropriate
bug, what do you recommend?
I think iotype would be enough. You can't pass type for platform
devices anyway, IIRC (the thing I don't quite like).
I just found that out the hard way,
Sergei Shtylyov wrote:
Marc St-Jean wrote:
Here is my second attempt at the serial driver patch for the
PMC-Sierra MSP71xx device.
There are three different fixes:
1. Fix for THRE errata
- I verified the UART_BUG_TXEN fix does not help with this erratum.
- I left our current
Sergei Shtylyov wrote:
> Hello.
>
> Marc St-Jean wrote:
>
> >> >>This I would hope you can hide in the platform specific
> >> >>serial_in/serial_out functions. If you write the UART_LCR save it in
> >> >>serial_out(), if you read IER etc.
>
> >> > I couldn't find hooks for platform specific
Hello.
Marc St-Jean wrote:
>>This I would hope you can hide in the platform specific
>>serial_in/serial_out functions. If you write the UART_LCR save it in
>>serial_out(), if you read IER etc.
> I couldn't find hooks for platform specific serial_in/out functions.
It's because there
Hello.
Marc St-Jean wrote:
http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20-rc4/2.6.20-rc4-mm1/broken-out/8250-uart-backup-timer.patch
This second patch failure description is identical to what we are seeing without
the THRE work-around. This must be the timer patch
Sergei Shtylyov wrote:
>
> >>This I would hope you can hide in the platform specific
> >>serial_in/serial_out functions. If you write the UART_LCR save it in
> >>serial_out(), if you read IER etc.
>
> > I couldn't find hooks for platform specific serial_in/out functions.
>
> It's
Sergei Shtylyov wrote:
> Hello, I wrote:
>
> Here is a serial driver patch for the PMC-Sierra MSP71xx device.
>
> There are three different fixes:
> 1. Fix for THRE errata
> 2. Fix for Busy Detect on LCR write
> 3. Workaround for interrupt/data concurrency issue
>
Hello.
Marc St-Jean wrote:
> 2. Fix for Busy Detect on LCR write
> 3. Workaround for interrupt/data concurrency issue
> case UPIO_MEM:
> +#ifdef CONFIG_PMC_MSP
> + /* Save the LCR value so it can be re-written when a
> + * Busy Detect interrupt occurs. */
> +
Hello.
Marc St-Jean wrote:
2. Fix for Busy Detect on LCR write
3. Workaround for interrupt/data concurrency issue
case UPIO_MEM:
+#ifdef CONFIG_PMC_MSP
+ /* Save the LCR value so it can be re-written when a
+ * Busy Detect interrupt occurs. */
+
Sergei Shtylyov wrote:
Hello, I wrote:
Here is a serial driver patch for the PMC-Sierra MSP71xx device.
There are three different fixes:
1. Fix for THRE errata
2. Fix for Busy Detect on LCR write
3. Workaround for interrupt/data concurrency issue
The first fix is handled
Sergei Shtylyov wrote:
This I would hope you can hide in the platform specific
serial_in/serial_out functions. If you write the UART_LCR save it in
serial_out(), if you read IER etc.
I couldn't find hooks for platform specific serial_in/out functions.
It's because there are
Hello.
Marc St-Jean wrote:
http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20-rc4/2.6.20-rc4-mm1/broken-out/8250-uart-backup-timer.patch
This second patch failure description is identical to what we are seeing without
the THRE work-around. This must be the timer patch
Hello.
Marc St-Jean wrote:
This I would hope you can hide in the platform specific
serial_in/serial_out functions. If you write the UART_LCR save it in
serial_out(), if you read IER etc.
I couldn't find hooks for platform specific serial_in/out functions.
It's because there are none.
Sergei Shtylyov wrote:
Hello.
Marc St-Jean wrote:
This I would hope you can hide in the platform specific
serial_in/serial_out functions. If you write the UART_LCR save it in
serial_out(), if you read IER etc.
I couldn't find hooks for platform specific serial_in/out
On Tue, 23 Jan 2007 14:37:23 -0800
Marc St-Jean <[EMAIL PROTECTED]> wrote:
> > This I would hope you can hide in the platform specific
> > serial_in/serial_out functions. If you write the UART_LCR save it in
> > serial_out(), if you read IER etc.
>
> I couldn't find hooks for platform specific
Alan wrote:
> > There are three different fixes:
> > 1. Fix for THRE errata
>
> That should be handled anyway. The current code actually spots this and
> uses a backup timer for dodgy UARTS
Thanks, I'll retest without this fix on the current l-m.o git master and see
if it still solves our
Alan wrote:
There are three different fixes:
1. Fix for THRE errata
That should be handled anyway. The current code actually spots this and
uses a backup timer for dodgy UARTS
Thanks, I'll retest without this fix on the current l-m.o git master and see
if it still solves our errata.
On Tue, 23 Jan 2007 14:37:23 -0800
Marc St-Jean [EMAIL PROTECTED] wrote:
This I would hope you can hide in the platform specific
serial_in/serial_out functions. If you write the UART_LCR save it in
serial_out(), if you read IER etc.
I couldn't find hooks for platform specific
CCing to linux-kernel as per AC's suggestion...
Original Message
Subject: RE: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master
Date: Mon, 22 Jan 2007 10:11:04 -0800
From: Marc St-Jean
To: Sergei Shtylyov
CC: <[EMAIL PROTECTED]>,
> -Original
CCing to linux-kernel as per AC's suggestion...
Original Message
Subject:Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git
mast er
Date: Mon, 22 Jan 2007 12:23:56 -0800
From: Sergei Shtylyov
Organization: MontaVista Software Inc.
To: Marc St-Jean
CC
CCing linux-kernel as per AC's suggestion...
> -Original Message-
> From: Ralf Baechle [mailto:[EMAIL PROTECTED]
> Sent: Friday, January 19, 2007 8:18 AM
> To: Marc St-Jean
> Cc: [EMAIL PROTECTED]; linux-serial@vger.kernel.org
> Subject: Re: [PATCH] serial driver PMC MSP71xx, kernel
CCing linux-kernel as per AC's suggestion...
-Original Message-
From: Ralf Baechle [mailto:[EMAIL PROTECTED]
Sent: Friday, January 19, 2007 8:18 AM
To: Marc St-Jean
Cc: [EMAIL PROTECTED]; linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial driver PMC MSP71xx, kernel
CCing to linux-kernel as per AC's suggestion...
Original Message
Subject: RE: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master
Date: Mon, 22 Jan 2007 10:11:04 -0800
From: Marc St-Jean
To: Sergei Shtylyov
CC: [EMAIL PROTECTED],linux-serial@vger.kernel.org
CCing to linux-kernel as per AC's suggestion...
Original Message
Subject:Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git
mast er
Date: Mon, 22 Jan 2007 12:23:56 -0800
From: Sergei Shtylyov
Organization: MontaVista Software Inc.
To: Marc St-Jean
CC
50 matches
Mail list logo
