[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-16 Thread Marc St-Jean
Serial driver patch for the PMC-Sierra MSP71xx devices. There are three different fixes: 1. Fix for DesignWare APB THRE errata: In brief, this is a non-standard 16550 in that the THRE interrupt will not re-assert itself simply by disabling and re-enabling the THRI bit in the IER, it is only

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-16 Thread Sergei Shtylyov
Hello. Andrew Morton wrote: + status = *(volatile u32 *)up->port.private_data; It distresses me that this patch uses a variable which this patch doesn't initialise anywhere. It isn't complete. I assume this gets passed via early_serial_setup(). Marc? The

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-16 Thread Sergei Shtylyov
Hello. Andrew Morton wrote: + status = *(volatile u32 *)up-port.private_data; It distresses me that this patch uses a variable which this patch doesn't initialise anywhere. It isn't complete. I assume this gets passed via early_serial_setup(). Marc? The

[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-16 Thread Marc St-Jean
Serial driver patch for the PMC-Sierra MSP71xx devices. There are three different fixes: 1. Fix for DesignWare APB THRE errata: In brief, this is a non-standard 16550 in that the THRE interrupt will not re-assert itself simply by disabling and re-enabling the THRI bit in the IER, it is only

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 13:26:29 -0600 Marc St-Jean <[EMAIL PROTECTED]> wrote: > + status = *(volatile u32 *)up->port.private_data; It distresses me that this patch uses a variable which this patch doesn't initialise anywhere. It isn't complete. The sub-driver code whch sets up

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-15 Thread Sergei Shtylyov
Hello. Marc St-Jean wrote: There are three different fixes: 1. Fix for DesignWare APB THRE errata: In brief, this is a non-standard 16550 in that the THRE interrupt will not re-assert itself simply by disabling and re-enabling the THRI bit in the IER, it is only re-enabled if a character is

[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-15 Thread Marc St-Jean
Seventh attempt at the serial driver patch for the PMC-Sierra MSP71xx devices. There are three different fixes: 1. Fix for DesignWare APB THRE errata: In brief, this is a non-standard 16550 in that the THRE interrupt will not re-assert itself simply by disabling and re-enabling the THRI bit in

[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-15 Thread Marc St-Jean
Seventh attempt at the serial driver patch for the PMC-Sierra MSP71xx devices. There are three different fixes: 1. Fix for DesignWare APB THRE errata: In brief, this is a non-standard 16550 in that the THRE interrupt will not re-assert itself simply by disabling and re-enabling the THRI bit in

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-15 Thread Sergei Shtylyov
Hello. Marc St-Jean wrote: There are three different fixes: 1. Fix for DesignWare APB THRE errata: In brief, this is a non-standard 16550 in that the THRE interrupt will not re-assert itself simply by disabling and re-enabling the THRI bit in the IER, it is only re-enabled if a character is

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 13:26:29 -0600 Marc St-Jean [EMAIL PROTECTED] wrote: + status = *(volatile u32 *)up-port.private_data; It distresses me that this patch uses a variable which this patch doesn't initialise anywhere. It isn't complete. The sub-driver code whch sets up

[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-09 Thread Marc St-Jean
Fifth attempt at the serial driver patch for the PMC-Sierra MSP71xx device. There are three different fixes: 1. Fix for DesignWare THRE errata - Dropped our fix since the "8250-uart-backup-timer.patch" in the "mm" tree also fixes it. This patch needs to be applied on top of "mm" patch. 2. Fix

[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-09 Thread Marc St-Jean
Fifth attempt at the serial driver patch for the PMC-Sierra MSP71xx device. There are three different fixes: 1. Fix for DesignWare THRE errata - Dropped our fix since the 8250-uart-backup-timer.patch in the mm tree also fixes it. This patch needs to be applied on top of mm patch. 2. Fix for Busy

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-08 Thread Sergei Shtylyov
Hello. Marc St-Jean wrote: Fourth attempt at the serial driver patch for the PMC-Sierra MSP71xx device. There are three different fixes: 1. Fix for DesignWare THRE errata - Dropped our fix since the "8250-uart-backup-timer.patch" in the "mm" tree also fixes it. This patch needs to be applied

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-08 Thread Sergei Shtylyov
Hello. Marc St-Jean wrote: Fourth attempt at the serial driver patch for the PMC-Sierra MSP71xx device. There are three different fixes: 1. Fix for DesignWare THRE errata - Dropped our fix since the 8250-uart-backup-timer.patch in the mm tree also fixes it. This patch needs to be applied on

[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-07 Thread Marc St-Jean
Fourth attempt at the serial driver patch for the PMC-Sierra MSP71xx device. There are three different fixes: 1. Fix for DesignWare THRE errata - Dropped our fix since the "8250-uart-backup-timer.patch" in the "mm" tree also fixes it. This patch needs to be applied on top of "mm" patch. 2. Fix

[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-07 Thread Marc St-Jean
Fourth attempt at the serial driver patch for the PMC-Sierra MSP71xx device. There are three different fixes: 1. Fix for DesignWare THRE errata - Dropped our fix since the 8250-uart-backup-timer.patch in the mm tree also fixes it. This patch needs to be applied on top of mm patch. 2. Fix for

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-05 Thread Alan
> unsigned char hub6; /* this should be in > the 8250 driver */ > unsigned char unused[3]; > + void*data; /* generic > platform data pointer */ > }; Convention is "private_data" > > /* > diff

[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-05 Thread Marc St-Jean
Third attempt at the serial driver patch for the PMC-Sierra MSP71xx device. There are three different fixes: 1. Fix for DesignWare THRE errata - Dropped our fix since the "8250-uart-backup-timer.patch" in the "mm" tree also fixes it. This patch needs to be applied on top of it. 2. Fix for Busy

[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-05 Thread Marc St-Jean
Third attempt at the serial driver patch for the PMC-Sierra MSP71xx device. There are three different fixes: 1. Fix for DesignWare THRE errata - Dropped our fix since the 8250-uart-backup-timer.patch in the mm tree also fixes it. This patch needs to be applied on top of it. 2. Fix for Busy

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-05 Thread Alan
unsigned char hub6; /* this should be in the 8250 driver */ unsigned char unused[3]; + void*data; /* generic platform data pointer */ }; Convention is private_data /* diff --git

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-01-25 Thread Sergei Shtylyov
Marc St-Jean wrote: Here is my second attempt at the serial driver patch for the PMC-Sierra MSP71xx device. There are three different fixes: 1. Fix for THRE errata - I verified the UART_BUG_TXEN fix does not help with this erratum. - I left our current fix in until I get our platform booting on

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-01-25 Thread Sergei Shtylyov
Marc St-Jean wrote: Here is my second attempt at the serial driver patch for the PMC-Sierra MSP71xx device. There are three different fixes: 1. Fix for THRE errata - I verified the UART_BUG_TXEN fix does not help with this erratum. - I left our current fix in until I get our platform booting on

[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-01-24 Thread Marc St-Jean
Here is my second attempt at the serial driver patch for the PMC-Sierra MSP71xx device. There are three different fixes: 1. Fix for THRE errata - I verified the UART_BUG_TXEN fix does not help with this erratum. - I left our current fix in until I get our platform booting on 2.6.20-rc4 to try the

[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-01-24 Thread Marc St-Jean
Here is my second attempt at the serial driver patch for the PMC-Sierra MSP71xx device. There are three different fixes: 1. Fix for THRE errata - I verified the UART_BUG_TXEN fix does not help with this erratum. - I left our current fix in until I get our platform booting on 2.6.20-rc4 to try the

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-01-22 Thread Alan
> There are three different fixes: > 1. Fix for THRE errata That should be handled anyway. The current code actually spots this and uses a backup timer for dodgy UARTS > 2. Fix for Busy Detect on LCR write > 3. Workaround for interrupt/data concurrency issue > case UPIO_MEM: > +#ifdef

[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-01-22 Thread Marc St-Jean
CCing linux-kernel as per AC's suggestion... -Original Message- From: Sergei Shtylyov Sent: Friday, January 19, 2007 9:05 AM To: Marc St-Jean Cc: [EMAIL PROTECTED]; linux-serial@vger.kernel.org Subject: Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master Hello. Marc St

[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-01-22 Thread Marc St-Jean
CCing linux-kernel as per AC's suggestion... On Thu, Jan 18, 2007 at 04:23:01PM -0800, Marc St-Jean wrote: > Index: linux_2_6/drivers/serial/8250.c > === > RCS file: linux_2_6/drivers/serial/8250.c,v retrieving revision > 1.1.1.7

[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-01-22 Thread Marc St-Jean
CCing linux-kernel as per AC's suggestion... Here is a serial driver patch for the PMC-Sierra MSP71xx device. There are three different fixes: 1. Fix for THRE errata 2. Fix for Busy Detect on LCR write 3. Workaround for interrupt/data concurrency issue The first fix is handled cleanly using a

[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-01-22 Thread Marc St-Jean
CCing linux-kernel as per AC's suggestion... Here is a serial driver patch for the PMC-Sierra MSP71xx device. There are three different fixes: 1. Fix for THRE errata 2. Fix for Busy Detect on LCR write 3. Workaround for interrupt/data concurrency issue The first fix is handled cleanly using a

[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-01-22 Thread Marc St-Jean
CCing linux-kernel as per AC's suggestion... On Thu, Jan 18, 2007 at 04:23:01PM -0800, Marc St-Jean wrote: Index: linux_2_6/drivers/serial/8250.c === RCS file: linux_2_6/drivers/serial/8250.c,v retrieving revision 1.1.1.7

[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-01-22 Thread Marc St-Jean
CCing linux-kernel as per AC's suggestion... -Original Message- From: Sergei Shtylyov Sent: Friday, January 19, 2007 9:05 AM To: Marc St-Jean Cc: [EMAIL PROTECTED]; linux-serial@vger.kernel.org Subject: Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master Hello. Marc St

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-01-22 Thread Alan
There are three different fixes: 1. Fix for THRE errata That should be handled anyway. The current code actually spots this and uses a backup timer for dodgy UARTS 2. Fix for Busy Detect on LCR write 3. Workaround for interrupt/data concurrency issue case UPIO_MEM: +#ifdef