Re: [PATCH] several returns before unlocking in lmc_ioctl

2007-10-30 Thread Kristof Provost
On 2007-10-30 20:15:12 (+0100), Roel Kluin <[EMAIL PROTECTED]> wrote: > Kristof Provost wrote: > > I think you have an extra curly brace there. It breaks compile on my > > system. > > You are right. thanks for notifying me and sorry for the trouble. > please revert my patch

Re: [PATCH] several returns before unlocking in lmc_ioctl

2007-10-30 Thread Roel Kluin
Kristof Provost wrote: > On 2007-10-23 03:47:48 (+0200), Roel Kluin <[EMAIL PROTECTED]> wrote: >> I think we should keep the lmc_tracing. Use this patch instead. >> >> -- >> Several returns before unlocking in lmc_ioctl >> >>

Re: [PATCH] several returns before unlocking in lmc_ioctl

2007-10-30 Thread Kristof Provost
On 2007-10-23 03:47:48 (+0200), Roel Kluin <[EMAIL PROTECTED]> wrote: > I think we should keep the lmc_tracing. Use this patch instead. > > -- > Several returns before unlocking in lmc_ioctl > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> > --- &

Re: [PATCH] several returns before unlocking in lmc_ioctl

2007-10-30 Thread Kristof Provost
On 2007-10-23 03:47:48 (+0200), Roel Kluin [EMAIL PROTECTED] wrote: I think we should keep the lmc_tracing. Use this patch instead. -- Several returns before unlocking in lmc_ioctl Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/net/wan/lmc/lmc_main.c b

Re: [PATCH] several returns before unlocking in lmc_ioctl

2007-10-30 Thread Roel Kluin
Kristof Provost wrote: On 2007-10-23 03:47:48 (+0200), Roel Kluin [EMAIL PROTECTED] wrote: I think we should keep the lmc_tracing. Use this patch instead. -- Several returns before unlocking in lmc_ioctl Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/net

Re: [PATCH] several returns before unlocking in lmc_ioctl

2007-10-30 Thread Kristof Provost
On 2007-10-30 20:15:12 (+0100), Roel Kluin [EMAIL PROTECTED] wrote: Kristof Provost wrote: I think you have an extra curly brace there. It breaks compile on my system. You are right. thanks for notifying me and sorry for the trouble. please revert my patch

Re: [PATCH] several returns before unlocking in lmc_ioctl

2007-10-22 Thread Roel Kluin
I think we should keep the lmc_tracing. Use this patch instead. -- Several returns before unlocking in lmc_ioctl Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c index 5ea8772..64eb578 100644 --- a/d

[PATCH] several returns before unlocking in lmc_ioctl

2007-10-22 Thread Roel Kluin
Several returns before unlocking in lmc_ioctl Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c index 5ea8772..af7b3e4 100644 --- a/drivers/net/wan/lmc/lmc_main.c +++ b/drivers/net/wan/lmc/lmc_main.c @@

[PATCH] several returns before unlocking in lmc_ioctl

2007-10-22 Thread Roel Kluin
Several returns before unlocking in lmc_ioctl Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c index 5ea8772..af7b3e4 100644 --- a/drivers/net/wan/lmc/lmc_main.c +++ b/drivers/net/wan/lmc/lmc_main.c @@ -142,9

Re: [PATCH] several returns before unlocking in lmc_ioctl

2007-10-22 Thread Roel Kluin
I think we should keep the lmc_tracing. Use this patch instead. -- Several returns before unlocking in lmc_ioctl Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c index 5ea8772..64eb578 100644 --- a/drivers