Re: [PATCH] sh: cmpxchg: fix a bit shift bug in big_endian os

2016-04-19 Thread Michael S. Tsirkin
On Tue, Apr 19, 2016 at 02:58:53PM +0800, Pan Xinhui wrote: > From: Pan Xinhui > > Correct bitoff in big endian OS. > > Fixes: 3226aad81aa6 ("sh: support 1 and 2 byte xchg") > Signed-off-by: Pan Xinhui I would add: current code

Re: [PATCH] sh: cmpxchg: fix a bit shift bug in big_endian os

2016-04-19 Thread Michael S. Tsirkin
On Tue, Apr 19, 2016 at 02:58:53PM +0800, Pan Xinhui wrote: > From: Pan Xinhui > > Correct bitoff in big endian OS. > > Fixes: 3226aad81aa6 ("sh: support 1 and 2 byte xchg") > Signed-off-by: Pan Xinhui I would add: current code works correctly for 1 byte but not for 2 bytes. Acked-by:

[PATCH] sh: cmpxchg: fix a bit shift bug in big_endian os

2016-04-19 Thread Pan Xinhui
From: Pan Xinhui Correct bitoff in big endian OS. Fixes: 3226aad81aa6 ("sh: support 1 and 2 byte xchg") Signed-off-by: Pan Xinhui --- arch/sh/include/asm/cmpxchg-xchg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] sh: cmpxchg: fix a bit shift bug in big_endian os

2016-04-19 Thread Pan Xinhui
From: Pan Xinhui Correct bitoff in big endian OS. Fixes: 3226aad81aa6 ("sh: support 1 and 2 byte xchg") Signed-off-by: Pan Xinhui --- arch/sh/include/asm/cmpxchg-xchg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sh/include/asm/cmpxchg-xchg.h