Re: [PATCH] sha: Enable cpuid check for Intel SHA extensions implementations

2015-08-21 Thread Tim Chen
On Thu, 2015-08-20 at 22:02 +0200, Thomas Gleixner wrote: > On Thu, 20 Aug 2015, Tim Chen wrote: > > From: Tim Chen > > Subject: [PATCH] sha: Enable cpuid check for Intel SHA extensions > > implementations > >sha: is not a proper subsystem name > >x8

Re: [PATCH] sha: Enable cpuid check for Intel SHA extensions implementations

2015-08-20 Thread Thomas Gleixner
On Thu, 20 Aug 2015, Tim Chen wrote: > From: Tim Chen > Subject: [PATCH] sha: Enable cpuid check for Intel SHA extensions > implementations sha: is not a proper subsystem name x86/cpufeatures: is the correct one > Enable cpuid check for Intel SHA extensions implementations

Re: [PATCH] sha: Enable cpuid check for Intel SHA extensions implementations

2015-08-20 Thread Tim Chen
> > Originally-by: Mouli > Signed-off-by: you > Thanks. Revised patch embedded below. Tim --->8--- From: Tim Chen Subject: [PATCH] sha: Enable cpuid check for Intel SHA extensions implementations The Intel Secure Hash Algorithm Extensions are designed to improve the perfor

Re: [PATCH] sha: Enable cpuid check for Intel SHA extensions implementations

2015-08-19 Thread Borislav Petkov
On Wed, Aug 19, 2015 at 09:49:58AM -0700, Tim Chen wrote: > On Tue, 2015-08-18 at 18:46 +0200, Thomas Gleixner wrote: > > On Mon, 17 Aug 2015, Tim Chen wrote: > > > Signed-off-by: Chandramouli Narayanan > > > Signed-off-by: Tim Chen > > > > And now the question who authored this complex one line

Re: [PATCH] sha: Enable cpuid check for Intel SHA extensions implementations

2015-08-19 Thread Tim Chen
On Tue, 2015-08-18 at 18:46 +0200, Thomas Gleixner wrote: > On Mon, 17 Aug 2015, Tim Chen wrote: > > Signed-off-by: Chandramouli Narayanan > > Signed-off-by: Tim Chen > > And now the question who authored this complex one liner > Mouli did the patch originally but he left the company. So

Re: [PATCH] sha: Enable cpuid check for Intel SHA extensions implementations

2015-08-18 Thread Thomas Gleixner
On Mon, 17 Aug 2015, Tim Chen wrote: > Signed-off-by: Chandramouli Narayanan > Signed-off-by: Tim Chen And now the question who authored this complex one liner > --- > arch/x86/include/asm/cpufeature.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/include/asm/cpufeatu

Re: [PATCH] sha: Enable cpuid check for Intel SHA extensions implementations

2015-08-17 Thread Tim Chen
we were encouraged to call cpu_has(X86_FEATURE_*) directly. > > In the patch description, it might also be nice to remind folks that > this will feature will also show up as "sha_ni" in /proc/cpuinfo. Okay, in that case, I've modified the patch to below: Tim ---&

Re: [PATCH] sha: Enable cpuid check for Intel SHA extensions implementations

2015-08-17 Thread Dave Hansen
On 08/17/2015 01:44 PM, Tim Chen wrote: > @@ -401,6 +402,7 @@ extern const char * const x86_bug_flags[NBUGINTS*32]; > #define cpu_has_eager_fpuboot_cpu_has(X86_FEATURE_EAGER_FPU) > #define cpu_has_topoext boot_cpu_has(X86_FEATURE_TOPOEXT) > #define cpu_has_bpextb

[PATCH] sha: Enable cpuid check for Intel SHA extensions implementations

2015-08-17 Thread Tim Chen
The Intel Secure Hash Algorithm Extensions are designed to improve the performance of SHA-1 and SHA-256. This patch adds the check for X86_FEATURE_SHA_NI bit. The SHA extension guide is found in chapter 8 of the Intel Architecture Instruction Set Extensions Programming reference: https://softwar