Re: [PATCH] shm: Fix the filename of hugetlb sysv shared memory

2007-06-11 Thread Ken Chen
On 6/11/07, Adam Litke <[EMAIL PROTECTED]> wrote: On 6/8/07, Eric W. Biederman <[EMAIL PROTECTED]> wrote: > -struct file *hugetlb_zero_setup(size_t size) > +struct file *hugetlb_file_setup(const char *name, size_t size) The bulk of this patch seems to handle renaming this function. Is that real

Re: [PATCH] shm: Fix the filename of hugetlb sysv shared memory

2007-06-11 Thread Badari Pulavarty
On Mon, 2007-06-11 at 11:11 -0700, Andrew Morton wrote: > On Fri, 08 Jun 2007 17:43:34 -0600 > [EMAIL PROTECTED] (Eric W. Biederman) wrote: > > > Some user space tools need to identify SYSV shared memory when > > examining /proc//maps. To do so they look for a block device > > with major zero, a

Re: [PATCH] shm: Fix the filename of hugetlb sysv shared memory

2007-06-11 Thread Adam Litke
On 6/8/07, Eric W. Biederman <[EMAIL PROTECTED]> wrote: -struct file *hugetlb_zero_setup(size_t size) +struct file *hugetlb_file_setup(const char *name, size_t size) The bulk of this patch seems to handle renaming this function. Is that really necessary? -- Adam Litke ( agl at us.ibm.com ) IB

Re: [PATCH] shm: Fix the filename of hugetlb sysv shared memory

2007-06-11 Thread Andrew Morton
On Fri, 08 Jun 2007 17:43:34 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: > Some user space tools need to identify SYSV shared memory when > examining /proc//maps. To do so they look for a block device > with major zero, a dentry named SYSV, and having the minor of > the internal sysv share

Re: [PATCH] shm: Fix the filename of hugetlb sysv shared memory

2007-06-09 Thread Eric W. Biederman
Badari Pulavarty <[EMAIL PROTECTED]> writes: > No. You still need my patch to fix the current breakage. Agreed. > This patch makes hugetlbfs also use same naming convention as regular shmem > for > its > name. This is not absolutely needed, its a nice to have. Currently, user space > tools > ca

Re: [PATCH] shm: Fix the filename of hugetlb sysv shared memory

2007-06-08 Thread Badari Pulavarty
Andrew Morton wrote: On Fri, 08 Jun 2007 17:43:34 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: Some user space tools need to identify SYSV shared memory when examining /proc//maps. To do so they look for a block device with major zero, a dentry named SYSV, and having the minor of the

Re: [PATCH] shm: Fix the filename of hugetlb sysv shared memory

2007-06-08 Thread Andrew Morton
On Fri, 08 Jun 2007 17:43:34 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: > Some user space tools need to identify SYSV shared memory when > examining /proc//maps. To do so they look for a block device > with major zero, a dentry named SYSV, and having the minor of > the internal sysv share

[PATCH] shm: Fix the filename of hugetlb sysv shared memory

2007-06-08 Thread Eric W. Biederman
Some user space tools need to identify SYSV shared memory when examining /proc//maps. To do so they look for a block device with major zero, a dentry named SYSV, and having the minor of the internal sysv shared memory kernel mount. To help these tools and to make it easier for people just browsi