Re: [PATCH] shrink task_struct by 16 bytes

2007-05-21 Thread Dave Airlie
Shrink task_struct by replacing the notifier callback with a notifier list that allows for multiple clients to register notifiers. It also saves one cacheline on i386. The patch also renames the un/block_all_signals() functions to more descriptive names signal_notifier_add/del() and updates the

Re: [PATCH] shrink task_struct by 16 bytes

2007-05-21 Thread Christoph Hellwig
Looks good. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] shrink task_struct by 16 bytes

2007-05-21 Thread Davi Arnaut
Christoph Hellwig wrote: > On Sun, May 20, 2007 at 12:40:11AM -0300, Davi Arnaut wrote: >> Hi, >> >> Shrink task_struct by replacing the notifier callback with a >> notifier list. The block_all_signals() function (and the signal >> notifier mechanism) has only one user at the moment, which is drm.

Re: [PATCH] shrink task_struct by 16 bytes

2007-05-21 Thread Christoph Hellwig
On Sun, May 20, 2007 at 12:40:11AM -0300, Davi Arnaut wrote: > Hi, > > Shrink task_struct by replacing the notifier callback with a > notifier list. The block_all_signals() function (and the signal > notifier mechanism) has only one user at the moment, which is drm. This looks like a nice improve

[PATCH] shrink task_struct by 16 bytes

2007-05-19 Thread Davi Arnaut
Hi, Shrink task_struct by replacing the notifier callback with a notifier list. The block_all_signals() function (and the signal notifier mechanism) has only one user at the moment, which is drm. Pahole output for task_struct: i386 before: /* size: 2640, cachelines: 42 */ /* sum members: