Re: [PATCH] slab.c ifdef reduction breaks build

On Mon, 29 Jan 2007, Christoph Lameter wrote: > On Mon, 29 Jan 2007, Andrew Morton wrote: > > > On Mon, 29 Jan 2007 12:41:33 -0800 (PST) > > Christoph Lameter <[EMAIL PROTECTED]> wrote: > > > > > +#ifdef CONFIG_ZONE_DMA > > > if (CONFIG_ZONE_DMA_FLAG) > > > > We don't need the `if (CO

Re: [PATCH] slab.c ifdef reduction breaks build

On Mon, 29 Jan 2007, Andrew Morton wrote: > On Mon, 29 Jan 2007 12:41:33 -0800 (PST) > Christoph Lameter <[EMAIL PROTECTED]> wrote: > > > +#ifdef CONFIG_ZONE_DMA > > if (CONFIG_ZONE_DMA_FLAG) > > We don't need the `if (CONFIG_ZONE_DMA_FLAG)' any more, do we? Correct. - To unsubscri

Re: [PATCH] slab.c ifdef reduction breaks build

On Mon, 29 Jan 2007 12:41:33 -0800 (PST) Christoph Lameter <[EMAIL PROTECTED]> wrote: > +#ifdef CONFIG_ZONE_DMA > if (CONFIG_ZONE_DMA_FLAG) We don't need the `if (CONFIG_ZONE_DMA_FLAG)' any more, do we? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH] slab.c ifdef reduction breaks build

I also hit the same issue. Here is the patch: Fix slab build failure if !CONFIG_ZONE_DMA I also needed this to get 2.6.20-rc6-mm2 to build. Fixes the fix by the complainer about the fixes. #ifdef cannot be avoided since cs_dmacachep is no longer defined. Signed-off-by: Christoph Lameter <[EMAIL

Re: [PATCH] slab.c ifdef reduction breaks build

On Mon, 29 Jan 2007, Jeff Dike wrote: > +#if CONFIG_ZONE_DMA_FLAG > + sizes->cs_dmacachep = kmem_cache_create( This would need to be #idef CONFIG_ZONE_DMA There have been some recent changes though so I am not sure what your codebase is. - To unsubscribe from this list: send the l

[PATCH] slab.c ifdef reduction breaks build

optional-zone_dma-in-the-vm-no-gfp_dma-check-in-the-slab-if- no-config_zone_dma-is-set-reduce-config_zone_dma-ifdefs converts some ifdefs into ifs. One of them causes cs_dmacachep to be referenced, when that field doesn't exist, because it's ifdefed on CONFIG_ZONE_DMA. I'd suggest reverting that