Re: [PATCH] slub: limit count of partial slabs scanned to gather statistics

2020-05-07 Thread Christopher Lameter
On Mon, 4 May 2020, Andrew Morton wrote: > But I guess it's better than nothing at all, unless there are > alternative ideas? I its highly unsusual to have such large partial lists. In a typical case allocations whould reduce the size of the lists. 1000s? That is scary. Are there inodes or

Re: [PATCH] slub: limit count of partial slabs scanned to gather statistics

2020-05-07 Thread David Rientjes
On Thu, 7 May 2020, Konstantin Khlebnikov wrote: > > > > To get exact count of free and used objects slub have to scan list of > > > > partial slabs. This may take at long time. Scanning holds spinlock and > > > > blocks allocations which move partial slabs to per-cpu lists and back. > > > > > >

Re: [PATCH] slub: limit count of partial slabs scanned to gather statistics

2020-05-07 Thread Vlastimil Babka
On 5/7/20 7:25 AM, Konstantin Khlebnikov wrote: > On 06/05/2020 14.56, Vlastimil Babka wrote: >> On 5/4/20 6:07 PM, Konstantin Khlebnikov wrote: >>> To get exact count of free and used objects slub have to scan list of >>> partial slabs. This may take at long time. Scanning holds spinlock and >>>

Re: [PATCH] slub: limit count of partial slabs scanned to gather statistics

2020-05-06 Thread Konstantin Khlebnikov
On 06/05/2020 14.56, Vlastimil Babka wrote: On 5/4/20 6:07 PM, Konstantin Khlebnikov wrote: To get exact count of free and used objects slub have to scan list of partial slabs. This may take at long time. Scanning holds spinlock and blocks allocations which move partial slabs to per-cpu lists

Re: [PATCH] slub: limit count of partial slabs scanned to gather statistics

2020-05-06 Thread Konstantin Khlebnikov
On 07/05/2020 06.01, Qian Cai wrote: On May 6, 2020, at 3:06 PM, Qian Cai wrote: On May 4, 2020, at 12:07 PM, Konstantin Khlebnikov wrote: To get exact count of free and used objects slub have to scan list of partial slabs. This may take at long time. Scanning holds spinlock and

Re: [PATCH] slub: limit count of partial slabs scanned to gather statistics

2020-05-06 Thread Stephen Rothwell
Hi Qian, On Wed, 6 May 2020 23:01:54 -0400 Qian Cai wrote: > > Andrew, Stephen, can you remove this patch from linux-next? Removed from linux-next. -- Cheers, Stephen Rothwell pgp6aRPJdbwvh.pgp Description: OpenPGP digital signature

Re: [PATCH] slub: limit count of partial slabs scanned to gather statistics

2020-05-06 Thread Qian Cai
> On May 6, 2020, at 3:06 PM, Qian Cai wrote: > > > >> On May 4, 2020, at 12:07 PM, Konstantin Khlebnikov >> wrote: >> >> To get exact count of free and used objects slub have to scan list of >> partial slabs. This may take at long time. Scanning holds spinlock and >> blocks allocations

Re: [PATCH] slub: limit count of partial slabs scanned to gather statistics

2020-05-06 Thread Qian Cai
> On May 4, 2020, at 12:07 PM, Konstantin Khlebnikov > wrote: > > To get exact count of free and used objects slub have to scan list of > partial slabs. This may take at long time. Scanning holds spinlock and > blocks allocations which move partial slabs to per-cpu lists and back. > >

Re: [PATCH] slub: limit count of partial slabs scanned to gather statistics

2020-05-06 Thread Vlastimil Babka
On 5/4/20 6:07 PM, Konstantin Khlebnikov wrote: > To get exact count of free and used objects slub have to scan list of > partial slabs. This may take at long time. Scanning holds spinlock and > blocks allocations which move partial slabs to per-cpu lists and back. > > Example found in the wild:

Re: [PATCH] slub: limit count of partial slabs scanned to gather statistics

2020-05-05 Thread Konstantin Khlebnikov
On 05/05/2020 00.19, David Rientjes wrote: On Mon, 4 May 2020, Konstantin Khlebnikov wrote: To get exact count of free and used objects slub have to scan list of partial slabs. This may take at long time. Scanning holds spinlock and blocks allocations which move partial slabs to per-cpu lists

Re: [PATCH] slub: limit count of partial slabs scanned to gather statistics

2020-05-04 Thread Konstantin Khlebnikov
On 04/05/2020 22.56, Andrew Morton wrote: On Mon, 04 May 2020 19:07:39 +0300 Konstantin Khlebnikov wrote: To get exact count of free and used objects slub have to scan list of partial slabs. This may take at long time. Scanning holds spinlock and blocks allocations which move partial slabs

Re: [PATCH] slub: limit count of partial slabs scanned to gather statistics

2020-05-04 Thread David Rientjes
On Mon, 4 May 2020, Konstantin Khlebnikov wrote: > To get exact count of free and used objects slub have to scan list of > partial slabs. This may take at long time. Scanning holds spinlock and > blocks allocations which move partial slabs to per-cpu lists and back. > > Example found in the

Re: [PATCH] slub: limit count of partial slabs scanned to gather statistics

2020-05-04 Thread Andrew Morton
On Mon, 04 May 2020 19:07:39 +0300 Konstantin Khlebnikov wrote: > To get exact count of free and used objects slub have to scan list of > partial slabs. This may take at long time. Scanning holds spinlock and > blocks allocations which move partial slabs to per-cpu lists and back. > > Example

[PATCH] slub: limit count of partial slabs scanned to gather statistics

2020-05-04 Thread Konstantin Khlebnikov
To get exact count of free and used objects slub have to scan list of partial slabs. This may take at long time. Scanning holds spinlock and blocks allocations which move partial slabs to per-cpu lists and back. Example found in the wild: # cat /sys/kernel/slab/dentry/partial 14478538 N0=7329569