Re: [PATCH] sm750fb: coding style fixes lines over 80 chars

2015-07-26 Thread Sudip Mukherjee
On Tue, Jul 21, 2015 at 03:17:06PM +0530, Vinay Simha wrote: > Joe, > > Just want to confirm, shall i delete this code in sm750_help.h, even the > FIELD_START and FIELD_END is not required. If they are not used anywhere feel free to send a patch to delete them. regards sudip -- To unsubscribe fro

Re: [PATCH] sm750fb: coding style fixes lines over 80 chars

2015-07-17 Thread Joe Perches
On Fri, 2015-07-17 at 12:58 +0530, Vinay Simha BN wrote: > scripts/checkpatch.pl kernel coding style fixes of WARNING Please use checkpatch's --strict option until you know kernel style much better. > diff --git a/drivers/staging/sm750fb/sm750_accel.h > b/drivers/staging/sm750fb/sm750_accel.h []

[PATCH] sm750fb: coding style fixes lines over 80 chars

2015-07-17 Thread Vinay Simha BN
scripts/checkpatch.pl kernel coding style fixes of WARNING WARNING: line over 80 characters Signed-off-by: Vinay Simha BN --- drivers/staging/sm750fb/ddk750_display.h | 10 +- drivers/staging/sm750fb/ddk750_hwi2c.h | 6 -- drivers/staging/sm750fb/ddk750_power.h | 6 +++--- dri

Re: [PATCH] sm750fb: coding style fixes lines over 80 chars

2015-07-17 Thread Vinay Simha
#if 0, but it's also obviously incorrect It supposed to be some tag #ifdef CONFIG_** . Could anybody in the loop can reply? i was just checking on style checks. Will skip this file , will take up later On Thu, Jul 16, 2015 at 9:27 AM, Joe Perches wrote: > On Thu, 2015-07-16 at 00:16 +0530, Vina

Re: [PATCH] sm750fb: coding style fixes lines over 80 chars

2015-07-15 Thread Joe Perches
On Thu, 2015-07-16 at 00:16 +0530, Vinay Simha BN wrote: > scripts/checkpatch.pl kernel coding style fixes of WARNING Please don't be a checkpatch robot. Use tools to prompt your brain, but don't ever turn your brain off. > diff --git a/drivers/staging/sm750fb/ddk750_help.h > b/drivers/staging/

[PATCH] sm750fb: coding style fixes lines over 80 chars

2015-07-15 Thread Vinay Simha BN
scripts/checkpatch.pl kernel coding style fixes of WARNING WARNING: line over 80 characters Signed-off-by: Vinay Simha BN --- drivers/staging/sm750fb/ddk750_display.h | 10 +- drivers/staging/sm750fb/ddk750_help.h| 6 -- drivers/staging/sm750fb/ddk750_hwi2c.h | 6 -- dri