Re: [PATCH] smp.c: Quit unconditionally enabling irqs in on_each_cpu_mask().

2013-08-12 Thread Andrew Morton
On Fri, 9 Aug 2013 12:24:56 -0700 David Daney wrote: > > otherwise the bugs > > stemming from incorrect use can be tricky to catch. > > > > ... all my patch does is allow on_each_cpu_mask() to be called with IRQs > disabled if we are in Early Boot. This is already the case with > smp_call_fun

Re: [PATCH] smp.c: Quit unconditionally enabling irqs in on_each_cpu_mask().

2013-08-09 Thread David Daney
On 08/09/2013 11:51 AM, Gilad Ben-Yossef wrote: On Thu, Aug 8, 2013 at 11:27 PM, David Daney wrote: On 08/08/2013 12:25 PM, Christoph Lameter wrote: On Thu, 8 Aug 2013, David Daney wrote: I don't know of any bugs currently caused by this unconditional local_irq_enable(), but I want to use

Re: [PATCH] smp.c: Quit unconditionally enabling irqs in on_each_cpu_mask().

2013-08-09 Thread Gilad Ben-Yossef
On Thu, Aug 8, 2013 at 11:27 PM, David Daney wrote: > > On 08/08/2013 12:25 PM, Christoph Lameter wrote: >> >> On Thu, 8 Aug 2013, David Daney wrote: >> >>> I don't know of any bugs currently caused by this unconditional >>> local_irq_enable(), but I want to use this function in MIPS/OCTEON >>> ea

Re: [PATCH] smp.c: Quit unconditionally enabling irqs in on_each_cpu_mask().

2013-08-08 Thread David Daney
On 08/08/2013 12:25 PM, Christoph Lameter wrote: On Thu, 8 Aug 2013, David Daney wrote: I don't know of any bugs currently caused by this unconditional local_irq_enable(), but I want to use this function in MIPS/OCTEON early boot (when we have early_boot_irqs_disabled). This also makes this fu

Re: [PATCH] smp.c: Quit unconditionally enabling irqs in on_each_cpu_mask().

2013-08-08 Thread Christoph Lameter
On Thu, 8 Aug 2013, David Daney wrote: > I don't know of any bugs currently caused by this unconditional > local_irq_enable(), but I want to use this function in MIPS/OCTEON > early boot (when we have early_boot_irqs_disabled). This also makes > this function have similar semantics to on_each_cpu

[PATCH] smp.c: Quit unconditionally enabling irqs in on_each_cpu_mask().

2013-08-08 Thread David Daney
From: David Daney As in f21afc25f9ed (smp.h: Use local_irq_{save,restore}() in !SMP version of on_each_cpu().), we don't want to enable irqs if they are not already enabled. I don't know of any bugs currently caused by this unconditional local_irq_enable(), but I want to use this function in MIP