Re: [PATCH] soc: integrator: remove unnecessary static in integrator_soc_init()

2017-08-03 Thread Gustavo A. R. Silva
Hi Linus, On 08/02/2017 06:58 AM, Linus Walleij wrote: On Thu, Jul 20, 2017 at 12:39 AM, Gustavo A. R. Silva wrote: Remove unnecessary static on local variable syscon_regmap. Such variables are initialized before being used, on every execution path throughout the

Re: [PATCH] soc: integrator: remove unnecessary static in integrator_soc_init()

2017-08-03 Thread Gustavo A. R. Silva
Hi Linus, On 08/02/2017 06:58 AM, Linus Walleij wrote: On Thu, Jul 20, 2017 at 12:39 AM, Gustavo A. R. Silva wrote: Remove unnecessary static on local variable syscon_regmap. Such variables are initialized before being used, on every execution path throughout the functions. So, the static

Re: [PATCH] soc: integrator: remove unnecessary static in integrator_soc_init()

2017-08-02 Thread Linus Walleij
On Thu, Jul 20, 2017 at 12:39 AM, Gustavo A. R. Silva wrote: > Remove unnecessary static on local variable syscon_regmap. > Such variables are initialized before being used, on every > execution path throughout the functions. So, the static has > no benefit. > > This

Re: [PATCH] soc: integrator: remove unnecessary static in integrator_soc_init()

2017-08-02 Thread Linus Walleij
On Thu, Jul 20, 2017 at 12:39 AM, Gustavo A. R. Silva wrote: > Remove unnecessary static on local variable syscon_regmap. > Such variables are initialized before being used, on every > execution path throughout the functions. So, the static has > no benefit. > > This issue was detected using

[PATCH] soc: integrator: remove unnecessary static in integrator_soc_init()

2017-07-19 Thread Gustavo A. R. Silva
Remove unnecessary static on local variable syscon_regmap. Such variables are initialized before being used, on every execution path throughout the functions. So, the static has no benefit. This issue was detected using Coccinelle and the following semantic patch: @bad exists@ position p;

[PATCH] soc: integrator: remove unnecessary static in integrator_soc_init()

2017-07-19 Thread Gustavo A. R. Silva
Remove unnecessary static on local variable syscon_regmap. Such variables are initialized before being used, on every execution path throughout the functions. So, the static has no benefit. This issue was detected using Coccinelle and the following semantic patch: @bad exists@ position p;