Re: [PATCH] soc: qcom: Add SoC info driver

2016-11-09 Thread Geert Uytterhoeven
Hi Bjorn, On Wed, Nov 2, 2016 at 5:28 PM, Bjorn Andersson wrote: > On Wed 26 Oct 07:05 PDT 2016, Arnd Bergmann wrote: >> On Wednesday, October 26, 2016 7:20:42 PM CEST Imran Khan wrote: >> > On 10/26/2016 2:19 AM, Arnd Bergmann wrote: >> > > On Tuesday, October 25,

Re: [PATCH] soc: qcom: Add SoC info driver

2016-11-09 Thread Geert Uytterhoeven
Hi Bjorn, On Wed, Nov 2, 2016 at 5:28 PM, Bjorn Andersson wrote: > On Wed 26 Oct 07:05 PDT 2016, Arnd Bergmann wrote: >> On Wednesday, October 26, 2016 7:20:42 PM CEST Imran Khan wrote: >> > On 10/26/2016 2:19 AM, Arnd Bergmann wrote: >> > > On Tuesday, October 25, 2016 3:23:34 PM CEST Imran

Re: [PATCH] soc: qcom: Add SoC info driver

2016-11-02 Thread Bjorn Andersson
On Wed 26 Oct 07:05 PDT 2016, Arnd Bergmann wrote: > On Wednesday, October 26, 2016 7:20:42 PM CEST Imran Khan wrote: > > On 10/26/2016 2:19 AM, Arnd Bergmann wrote: > > > On Tuesday, October 25, 2016 3:23:34 PM CEST Imran Khan wrote: > > >> On 10/21/2016 4:03 PM, Arnd Bergmann wrote: > >

Re: [PATCH] soc: qcom: Add SoC info driver

2016-11-02 Thread Bjorn Andersson
On Wed 26 Oct 07:05 PDT 2016, Arnd Bergmann wrote: > On Wednesday, October 26, 2016 7:20:42 PM CEST Imran Khan wrote: > > On 10/26/2016 2:19 AM, Arnd Bergmann wrote: > > > On Tuesday, October 25, 2016 3:23:34 PM CEST Imran Khan wrote: > > >> On 10/21/2016 4:03 PM, Arnd Bergmann wrote: > >

Re: [PATCH] soc: qcom: Add SoC info driver

2016-11-02 Thread Arnd Bergmann
On Wednesday 02 November 2016, Imran Khan wrote: > On 10/27/2016 7:11 PM, Arnd Bergmann wrote: > > On Thursday, October 27, 2016 6:40:27 PM CEST Imran Khan wrote: > >> On 10/26/2016 8:16 PM, Arnd Bergmann wrote: > >>> On Wednesday, October 26, 2016 7:42:08 PM CEST Imran Khan wrote: > >> > >> Yes.

Re: [PATCH] soc: qcom: Add SoC info driver

2016-11-02 Thread Arnd Bergmann
On Wednesday 02 November 2016, Imran Khan wrote: > On 10/27/2016 7:11 PM, Arnd Bergmann wrote: > > On Thursday, October 27, 2016 6:40:27 PM CEST Imran Khan wrote: > >> On 10/26/2016 8:16 PM, Arnd Bergmann wrote: > >>> On Wednesday, October 26, 2016 7:42:08 PM CEST Imran Khan wrote: > >> > >> Yes.

Re: [PATCH] soc: qcom: Add SoC info driver

2016-11-02 Thread Imran Khan
On 10/27/2016 7:11 PM, Arnd Bergmann wrote: > On Thursday, October 27, 2016 6:40:27 PM CEST Imran Khan wrote: >> On 10/26/2016 8:16 PM, Arnd Bergmann wrote: >>> On Wednesday, October 26, 2016 7:42:08 PM CEST Imran Khan wrote: On 10/26/2016 7:35 PM, Arnd Bergmann wrote: >>> As we are

Re: [PATCH] soc: qcom: Add SoC info driver

2016-11-02 Thread Imran Khan
On 10/27/2016 7:11 PM, Arnd Bergmann wrote: > On Thursday, October 27, 2016 6:40:27 PM CEST Imran Khan wrote: >> On 10/26/2016 8:16 PM, Arnd Bergmann wrote: >>> On Wednesday, October 26, 2016 7:42:08 PM CEST Imran Khan wrote: On 10/26/2016 7:35 PM, Arnd Bergmann wrote: >>> As we are

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-27 Thread Arnd Bergmann
On Thursday, October 27, 2016 6:40:27 PM CEST Imran Khan wrote: > On 10/26/2016 8:16 PM, Arnd Bergmann wrote: > > On Wednesday, October 26, 2016 7:42:08 PM CEST Imran Khan wrote: > >> On 10/26/2016 7:35 PM, Arnd Bergmann wrote: > > As we are talking about generic soc_device_attribute fields, I

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-27 Thread Arnd Bergmann
On Thursday, October 27, 2016 6:40:27 PM CEST Imran Khan wrote: > On 10/26/2016 8:16 PM, Arnd Bergmann wrote: > > On Wednesday, October 26, 2016 7:42:08 PM CEST Imran Khan wrote: > >> On 10/26/2016 7:35 PM, Arnd Bergmann wrote: > > As we are talking about generic soc_device_attribute fields, I

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-27 Thread Imran Khan
On 10/26/2016 8:16 PM, Arnd Bergmann wrote: > On Wednesday, October 26, 2016 7:42:08 PM CEST Imran Khan wrote: >> On 10/26/2016 7:35 PM, Arnd Bergmann wrote: > As we are talking about generic soc_device_attribute fields, I was hoping > that > having a vendor field would be helpful as

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-27 Thread Imran Khan
On 10/26/2016 8:16 PM, Arnd Bergmann wrote: > On Wednesday, October 26, 2016 7:42:08 PM CEST Imran Khan wrote: >> On 10/26/2016 7:35 PM, Arnd Bergmann wrote: > As we are talking about generic soc_device_attribute fields, I was hoping > that > having a vendor field would be helpful as

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-26 Thread Arnd Bergmann
On Wednesday, October 26, 2016 7:42:08 PM CEST Imran Khan wrote: > On 10/26/2016 7:35 PM, Arnd Bergmann wrote: > >> > As we are talking about generic soc_device_attribute fields, I was > >> > hoping that > >> > having a vendor field would be helpful as along with family it would > >> > provide >

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-26 Thread Arnd Bergmann
On Wednesday, October 26, 2016 7:42:08 PM CEST Imran Khan wrote: > On 10/26/2016 7:35 PM, Arnd Bergmann wrote: > >> > As we are talking about generic soc_device_attribute fields, I was > >> > hoping that > >> > having a vendor field would be helpful as along with family it would > >> > provide >

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-26 Thread Imran Khan
On 10/26/2016 7:35 PM, Arnd Bergmann wrote: >> > As we are talking about generic soc_device_attribute fields, I was hoping >> > that >> > having a vendor field would be helpful as along with family it would >> > provide >> > a more thorough information. Also as more than one foundries may be

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-26 Thread Imran Khan
On 10/26/2016 7:35 PM, Arnd Bergmann wrote: >> > As we are talking about generic soc_device_attribute fields, I was hoping >> > that >> > having a vendor field would be helpful as along with family it would >> > provide >> > a more thorough information. Also as more than one foundries may be

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-26 Thread Arnd Bergmann
On Wednesday, October 26, 2016 7:20:42 PM CEST Imran Khan wrote: > On 10/26/2016 2:19 AM, Arnd Bergmann wrote: > > On Tuesday, October 25, 2016 3:23:34 PM CEST Imran Khan wrote: > >> On 10/21/2016 4:03 PM, Arnd Bergmann wrote: > +/* socinfo: sysfs functions */ > >>> > >>> This seems overly

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-26 Thread Arnd Bergmann
On Wednesday, October 26, 2016 7:20:42 PM CEST Imran Khan wrote: > On 10/26/2016 2:19 AM, Arnd Bergmann wrote: > > On Tuesday, October 25, 2016 3:23:34 PM CEST Imran Khan wrote: > >> On 10/21/2016 4:03 PM, Arnd Bergmann wrote: > +/* socinfo: sysfs functions */ > >>> > >>> This seems overly

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-26 Thread Imran Khan
On 10/26/2016 2:19 AM, Arnd Bergmann wrote: > On Tuesday, October 25, 2016 3:23:34 PM CEST Imran Khan wrote: >> On 10/21/2016 4:03 PM, Arnd Bergmann wrote: +/* socinfo: sysfs functions */ >>> >>> This seems overly verbose, having both raw and human-readable >>> IDs is generally not necessary,

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-26 Thread Imran Khan
On 10/26/2016 2:19 AM, Arnd Bergmann wrote: > On Tuesday, October 25, 2016 3:23:34 PM CEST Imran Khan wrote: >> On 10/21/2016 4:03 PM, Arnd Bergmann wrote: +/* socinfo: sysfs functions */ >>> >>> This seems overly verbose, having both raw and human-readable >>> IDs is generally not necessary,

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-25 Thread Arnd Bergmann
On Tuesday, October 25, 2016 3:23:34 PM CEST Imran Khan wrote: > On 10/21/2016 4:03 PM, Arnd Bergmann wrote: > >> +/* socinfo: sysfs functions */ > > > > This seems overly verbose, having both raw and human-readable > > IDs is generally not necessary, pick one of the two. If you > > need any

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-25 Thread Arnd Bergmann
On Tuesday, October 25, 2016 3:23:34 PM CEST Imran Khan wrote: > On 10/21/2016 4:03 PM, Arnd Bergmann wrote: > >> +/* socinfo: sysfs functions */ > > > > This seems overly verbose, having both raw and human-readable > > IDs is generally not necessary, pick one of the two. If you > > need any

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-25 Thread Imran Khan
On 10/21/2016 4:03 PM, Arnd Bergmann wrote: > On Thursday, October 20, 2016 7:36:22 PM CEST Imran Khan wrote: >> +#include >> +#include >> + >> +#include > > I don't see anything here that needs asm/system_misc.h > Okay. I will not use this header file here. >> +const char *hw_platform[] =

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-25 Thread Imran Khan
On 10/21/2016 4:03 PM, Arnd Bergmann wrote: > On Thursday, October 20, 2016 7:36:22 PM CEST Imran Khan wrote: >> +#include >> +#include >> + >> +#include > > I don't see anything here that needs asm/system_misc.h > Okay. I will not use this header file here. >> +const char *hw_platform[] =

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-25 Thread Imran Khan
On 10/20/2016 8:50 PM, Andy Gross wrote: > On Thu, Oct 20, 2016 at 07:36:22PM +0530, Imran Khan wrote: >> The SoC info driver provides information such as Chip ID, >> Chip family, serial number and other such details about >> Qualcomm SoCs. >> >> Signed-off-by: Imran Khan

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-25 Thread Imran Khan
On 10/20/2016 8:50 PM, Andy Gross wrote: > On Thu, Oct 20, 2016 at 07:36:22PM +0530, Imran Khan wrote: >> The SoC info driver provides information such as Chip ID, >> Chip family, serial number and other such details about >> Qualcomm SoCs. >> >> Signed-off-by: Imran Khan >> --- >>

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-21 Thread Arnd Bergmann
On Thursday, October 20, 2016 7:36:22 PM CEST Imran Khan wrote: > +#include > +#include > + > +#include I don't see anything here that needs asm/system_misc.h > +const char *hw_platform[] = { > + [HW_PLATFORM_UNKNOWN] = "Unknown", > + [HW_PLATFORM_SURF] = "Surf", > +

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-21 Thread Arnd Bergmann
On Thursday, October 20, 2016 7:36:22 PM CEST Imran Khan wrote: > +#include > +#include > + > +#include I don't see anything here that needs asm/system_misc.h > +const char *hw_platform[] = { > + [HW_PLATFORM_UNKNOWN] = "Unknown", > + [HW_PLATFORM_SURF] = "Surf", > +

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-20 Thread Andy Gross
On Thu, Oct 20, 2016 at 07:36:22PM +0530, Imran Khan wrote: > The SoC info driver provides information such as Chip ID, > Chip family, serial number and other such details about > Qualcomm SoCs. > > Signed-off-by: Imran Khan > --- >

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-20 Thread Andy Gross
On Thu, Oct 20, 2016 at 07:36:22PM +0530, Imran Khan wrote: > The SoC info driver provides information such as Chip ID, > Chip family, serial number and other such details about > Qualcomm SoCs. > > Signed-off-by: Imran Khan > --- > .../devicetree/bindings/soc/qcom/qcom,socinfo.txt | 18 + >

[PATCH] soc: qcom: Add SoC info driver

2016-10-20 Thread Imran Khan
The SoC info driver provides information such as Chip ID, Chip family, serial number and other such details about Qualcomm SoCs. Signed-off-by: Imran Khan --- .../devicetree/bindings/soc/qcom/qcom,socinfo.txt | 18 + drivers/soc/qcom/socinfo.c |

[PATCH] soc: qcom: Add SoC info driver

2016-10-20 Thread Imran Khan
The SoC info driver provides information such as Chip ID, Chip family, serial number and other such details about Qualcomm SoCs. Signed-off-by: Imran Khan --- .../devicetree/bindings/soc/qcom/qcom,socinfo.txt | 18 + drivers/soc/qcom/socinfo.c | 1173

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-20 Thread Mark Rutland
On Thu, Oct 20, 2016 at 07:36:22PM +0530, Imran Khan wrote: > The SoC info driver provides information such as Chip ID, > Chip family, serial number and other such details about > Qualcomm SoCs. > > Signed-off-by: Imran Khan > --- >

Re: [PATCH] soc: qcom: Add SoC info driver

2016-10-20 Thread Mark Rutland
On Thu, Oct 20, 2016 at 07:36:22PM +0530, Imran Khan wrote: > The SoC info driver provides information such as Chip ID, > Chip family, serial number and other such details about > Qualcomm SoCs. > > Signed-off-by: Imran Khan > --- > .../devicetree/bindings/soc/qcom/qcom,socinfo.txt | 18 + >