Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-26 Thread Neil Leeder
On 5/26/2016 12:48 AM, Bjorn Andersson wrote: > On Tue 24 May 12:54 PDT 2016, Neil Leeder wrote: > >> >> >> On 5/24/2016 07:23 AM, Mark Rutland wrote: >>> On Mon, May 23, 2016 at 02:22:59PM -0400, Neil Leeder wrote: On 5/23/2016 01:25 PM, Mark Rutland wrote: > On Fri, May 20, 2016

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-26 Thread Neil Leeder
On 5/26/2016 12:48 AM, Bjorn Andersson wrote: > On Tue 24 May 12:54 PDT 2016, Neil Leeder wrote: > >> >> >> On 5/24/2016 07:23 AM, Mark Rutland wrote: >>> On Mon, May 23, 2016 at 02:22:59PM -0400, Neil Leeder wrote: On 5/23/2016 01:25 PM, Mark Rutland wrote: > On Fri, May 20, 2016

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-25 Thread Bjorn Andersson
On Tue 24 May 12:54 PDT 2016, Neil Leeder wrote: > > > On 5/24/2016 07:23 AM, Mark Rutland wrote: > > On Mon, May 23, 2016 at 02:22:59PM -0400, Neil Leeder wrote: > >> > >> On 5/23/2016 01:25 PM, Mark Rutland wrote: > >>> On Fri, May 20, 2016 at 03:13:07PM -0400, Neil Leeder wrote: > >

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-25 Thread Bjorn Andersson
On Tue 24 May 12:54 PDT 2016, Neil Leeder wrote: > > > On 5/24/2016 07:23 AM, Mark Rutland wrote: > > On Mon, May 23, 2016 at 02:22:59PM -0400, Neil Leeder wrote: > >> > >> On 5/23/2016 01:25 PM, Mark Rutland wrote: > >>> On Fri, May 20, 2016 at 03:13:07PM -0400, Neil Leeder wrote: > >

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-24 Thread Neil Leeder
On 5/24/2016 07:23 AM, Mark Rutland wrote: > On Mon, May 23, 2016 at 02:22:59PM -0400, Neil Leeder wrote: >> >> On 5/23/2016 01:25 PM, Mark Rutland wrote: >>> On Fri, May 20, 2016 at 03:13:07PM -0400, Neil Leeder wrote: Signed-off-by: Neil Leeder ---

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-24 Thread Neil Leeder
On 5/24/2016 07:23 AM, Mark Rutland wrote: > On Mon, May 23, 2016 at 02:22:59PM -0400, Neil Leeder wrote: >> >> On 5/23/2016 01:25 PM, Mark Rutland wrote: >>> On Fri, May 20, 2016 at 03:13:07PM -0400, Neil Leeder wrote: Signed-off-by: Neil Leeder --- drivers/soc/qcom/Kconfig

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-24 Thread Mark Rutland
On Mon, May 23, 2016 at 02:22:59PM -0400, Neil Leeder wrote: > > On 5/23/2016 01:25 PM, Mark Rutland wrote: > > On Fri, May 20, 2016 at 03:13:07PM -0400, Neil Leeder wrote: > >> L2 registers are accessed using a select register and data > >> register pair. To prevent multiple concurrent writes to

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-24 Thread Mark Rutland
On Mon, May 23, 2016 at 02:22:59PM -0400, Neil Leeder wrote: > > On 5/23/2016 01:25 PM, Mark Rutland wrote: > > On Fri, May 20, 2016 at 03:13:07PM -0400, Neil Leeder wrote: > >> L2 registers are accessed using a select register and data > >> register pair. To prevent multiple concurrent writes to

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-23 Thread Timur Tabi
Christopher Covington wrote: They ended up calling the pinctrl file qcom/pinctrl/qdf2xxx.c. http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=8f1338cd80648adf5434798f5393ad7c55d10848 To be fair, none of the other drivers in drivers/soc/ specify any specific SOCs.

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-23 Thread Timur Tabi
Christopher Covington wrote: They ended up calling the pinctrl file qcom/pinctrl/qdf2xxx.c. http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=8f1338cd80648adf5434798f5393ad7c55d10848 To be fair, none of the other drivers in drivers/soc/ specify any specific SOCs.

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-23 Thread Christopher Covington
On 05/23/2016 02:22 PM, Neil Leeder wrote: > > On 5/23/2016 01:25 PM, Mark Rutland wrote: >> On Fri, May 20, 2016 at 03:13:07PM -0400, Neil Leeder wrote: >>> L2 registers are accessed using a select register and data >>> register pair. To prevent multiple concurrent writes to the >>> select

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-23 Thread Christopher Covington
On 05/23/2016 02:22 PM, Neil Leeder wrote: > > On 5/23/2016 01:25 PM, Mark Rutland wrote: >> On Fri, May 20, 2016 at 03:13:07PM -0400, Neil Leeder wrote: >>> L2 registers are accessed using a select register and data >>> register pair. To prevent multiple concurrent writes to the >>> select

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-23 Thread Neil Leeder
On 5/23/2016 01:25 PM, Mark Rutland wrote: > On Fri, May 20, 2016 at 03:13:07PM -0400, Neil Leeder wrote: >> L2 registers are accessed using a select register and data >> register pair. To prevent multiple concurrent writes to the >> select register by independent drivers, the write to the >>

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-23 Thread Neil Leeder
On 5/23/2016 01:25 PM, Mark Rutland wrote: > On Fri, May 20, 2016 at 03:13:07PM -0400, Neil Leeder wrote: >> L2 registers are accessed using a select register and data >> register pair. To prevent multiple concurrent writes to the >> select register by independent drivers, the write to the >>

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-23 Thread Neil Leeder
On 5/23/2016 01:04 PM, Stephen Boyd wrote: > On 05/23/2016 08:43 AM, Neil Leeder wrote: >> >> On 5/20/2016 05:19 PM, Stephen Boyd wrote: >> >>> >>> Is there a patch to add sysreg.h to arch/arm? It would be nice to use >>> one l2 accessor API on arm64 and arm. >>> >> Sounds like a good thing for

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-23 Thread Neil Leeder
On 5/23/2016 01:04 PM, Stephen Boyd wrote: > On 05/23/2016 08:43 AM, Neil Leeder wrote: >> >> On 5/20/2016 05:19 PM, Stephen Boyd wrote: >> >>> >>> Is there a patch to add sysreg.h to arch/arm? It would be nice to use >>> one l2 accessor API on arm64 and arm. >>> >> Sounds like a good thing for

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-23 Thread Mark Rutland
On Fri, May 20, 2016 at 03:13:07PM -0400, Neil Leeder wrote: > L2 registers are accessed using a select register and data > register pair. To prevent multiple concurrent writes to the > select register by independent drivers, the write to the > select register and the associated access of the data

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-23 Thread Mark Rutland
On Fri, May 20, 2016 at 03:13:07PM -0400, Neil Leeder wrote: > L2 registers are accessed using a select register and data > register pair. To prevent multiple concurrent writes to the > select register by independent drivers, the write to the > select register and the associated access of the data

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-23 Thread Stephen Boyd
On 05/23/2016 08:43 AM, Neil Leeder wrote: > > On 5/20/2016 05:19 PM, Stephen Boyd wrote: > >> >> Is there a patch to add sysreg.h to arch/arm? It would be nice to use >> one l2 accessor API on arm64 and arm. >> > Sounds like a good thing for the next person who submits a krait L2 patch to >

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-23 Thread Stephen Boyd
On 05/23/2016 08:43 AM, Neil Leeder wrote: > > On 5/20/2016 05:19 PM, Stephen Boyd wrote: > >> >> Is there a patch to add sysreg.h to arch/arm? It would be nice to use >> one l2 accessor API on arm64 and arm. >> > Sounds like a good thing for the next person who submits a krait L2 patch to >

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-23 Thread Neil Leeder
On 5/20/2016 05:19 PM, Stephen Boyd wrote: > On 05/20/2016 12:13 PM, Neil Leeder wrote: >> diff --git a/drivers/soc/qcom/l2-accessors.c >> b/drivers/soc/qcom/l2-accessors.c >> new file mode 100644 >> index 000..fbb69bd >> --- /dev/null >> +++ b/drivers/soc/qcom/l2-accessors.c >> @@ -0,0

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-23 Thread Neil Leeder
On 5/20/2016 05:19 PM, Stephen Boyd wrote: > On 05/20/2016 12:13 PM, Neil Leeder wrote: >> diff --git a/drivers/soc/qcom/l2-accessors.c >> b/drivers/soc/qcom/l2-accessors.c >> new file mode 100644 >> index 000..fbb69bd >> --- /dev/null >> +++ b/drivers/soc/qcom/l2-accessors.c >> @@ -0,0

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-20 Thread Stephen Boyd
On 05/20/2016 12:13 PM, Neil Leeder wrote: > diff --git a/drivers/soc/qcom/l2-accessors.c b/drivers/soc/qcom/l2-accessors.c > new file mode 100644 > index 000..fbb69bd > --- /dev/null > +++ b/drivers/soc/qcom/l2-accessors.c > @@ -0,0 +1,66 @@ > +/* > + * Copyright (c) 2014-2016 The Linux

Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-20 Thread Stephen Boyd
On 05/20/2016 12:13 PM, Neil Leeder wrote: > diff --git a/drivers/soc/qcom/l2-accessors.c b/drivers/soc/qcom/l2-accessors.c > new file mode 100644 > index 000..fbb69bd > --- /dev/null > +++ b/drivers/soc/qcom/l2-accessors.c > @@ -0,0 +1,66 @@ > +/* > + * Copyright (c) 2014-2016 The Linux

[PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-20 Thread Neil Leeder
L2 registers are accessed using a select register and data register pair. To prevent multiple concurrent writes to the select register by independent drivers, the write to the select register and the associated access of the data register are protected with a lock. All drivers accessing the L2

[PATCH] soc: qcom: provide mechanism for drivers to access L2 registers

2016-05-20 Thread Neil Leeder
L2 registers are accessed using a select register and data register pair. To prevent multiple concurrent writes to the select register by independent drivers, the write to the select register and the associated access of the data register are protected with a lock. All drivers accessing the L2