Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS

2018-09-28 Thread Alex Elder
On 09/28/2018 12:21 PM, Bjorn Andersson wrote: >> I have CONFIG_IPA dependent on CONFIG_QCOM_QMI_HELPERS. I could >> change that to select it instead but I still think this entry >> should be changed. I was thinking one of two changes: - Add the prompt string (which I suggested) - Don't add the p

Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS

2018-09-28 Thread Bjorn Andersson
On Fri 28 Sep 06:23 PDT 2018, Alex Elder wrote: > On 09/28/2018 07:26 AM, Niklas Cassel wrote: > > On Fri, Sep 28, 2018 at 06:41:11AM -0500, Alex Elder wrote: > >> Was there something wrong with this patch? I sent it a long time > >> ago but it still applies cleanly. I can re-send if you like. >

Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS

2018-09-28 Thread Niklas Cassel
On Fri, Sep 28, 2018 at 08:23:03AM -0500, Alex Elder wrote: > On 09/28/2018 07:26 AM, Niklas Cassel wrote: > > On Fri, Sep 28, 2018 at 06:41:11AM -0500, Alex Elder wrote: > >> Was there something wrong with this patch? I sent it a long time > >> ago but it still applies cleanly. I can re-send if

Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS

2018-09-28 Thread Alex Elder
On 09/28/2018 07:26 AM, Niklas Cassel wrote: > On Fri, Sep 28, 2018 at 06:41:11AM -0500, Alex Elder wrote: >> Was there something wrong with this patch? I sent it a long time >> ago but it still applies cleanly. I can re-send if you like. > > Hello Alex, > > This patch does not apply on top of

Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS

2018-09-28 Thread Niklas Cassel
On Fri, Sep 28, 2018 at 06:41:11AM -0500, Alex Elder wrote: > Was there something wrong with this patch? I sent it a long time > ago but it still applies cleanly. I can re-send if you like. Hello Alex, This patch does not apply on top of https://git.kernel.org/pub/scm/linux/kernel/git/agross/li

Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS

2018-09-28 Thread Alex Elder
Was there something wrong with this patch? I sent it a long time ago but it still applies cleanly. I can re-send if you like. -Alex On 04/27/2018 09:03 AM, Alex Elder wrote: > Add a prompt to the "tristate" attribute in the Kconfig file in > which QCOM_QM

[PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS

2018-04-27 Thread Alex Elder
Add a prompt to the "tristate" attribute in the Kconfig file in which QCOM_QMI_HELPERS is defined; I find it doesn't get selected without it. Signed-off-by: Alex Elder --- drivers/soc/qcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/Kconfig b/driv