Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

On Wed, Jun 20, 2018 at 04:05:13PM -0400, Steven Rostedt wrote: > > Peter, can you ack this. > > On Thu, 26 Apr 2018 21:11:00 -0700 > Joel Fernandes wrote: > > > I'm able to reproduce a lockdep splat when CONFIG_PROVE_LOCKING=y and > > CONFIG_PREEMPTIRQ_EVENTS=y. > > > > $ echo 1 >

Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

On Wed, Jun 20, 2018 at 04:05:13PM -0400, Steven Rostedt wrote: > > Peter, can you ack this. > > On Thu, 26 Apr 2018 21:11:00 -0700 > Joel Fernandes wrote: > > > I'm able to reproduce a lockdep splat when CONFIG_PROVE_LOCKING=y and > > CONFIG_PREEMPTIRQ_EVENTS=y. > > > > $ echo 1 >

Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

Peter, can you ack this. On Thu, 26 Apr 2018 21:11:00 -0700 Joel Fernandes wrote: > I'm able to reproduce a lockdep splat when CONFIG_PROVE_LOCKING=y and > CONFIG_PREEMPTIRQ_EVENTS=y. > > $ echo 1 > /d/tracing/events/preemptirq/preempt_enable/enable > --- BTW, the "---" here causes git to

Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

Peter, can you ack this. On Thu, 26 Apr 2018 21:11:00 -0700 Joel Fernandes wrote: > I'm able to reproduce a lockdep splat when CONFIG_PROVE_LOCKING=y and > CONFIG_PREEMPTIRQ_EVENTS=y. > > $ echo 1 > /d/tracing/events/preemptirq/preempt_enable/enable > --- BTW, the "---" here causes git to

Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

t; > ---8<--- > > From: "Joel Fernandes (Google)" > Date: Tue, 1 May 2018 18:44:39 -0700 > Subject: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat > > I'm able to reproduce a lockdep splat with config options: > CONFIG_P

Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

t; > ---8<--- > > From: "Joel Fernandes (Google)" > Date: Tue, 1 May 2018 18:44:39 -0700 > Subject: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat > > I'm able to reproduce a lockdep splat with config options: > CONFIG_P

Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

oel ---8<--- From: "Joel Fernandes (Google)" Date: Tue, 1 May 2018 18:44:39 -0700 Subject: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat I'm able to reproduce a lockdep splat with config options: CONFIG_PROVE_LOCKING=y, CON

Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

oel ---8<--- From: "Joel Fernandes (Google)" Date: Tue, 1 May 2018 18:44:39 -0700 Subject: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat I'm able to reproduce a lockdep splat with config options: CONFIG_PROVE_LOCKING=y, CON

Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

Peter, Ingo or Thomas, Can you queue this up? Or would you prefer that I take it? -- Steve On Tue, 1 May 2018 18:44:39 -0700 Joel Fernandes wrote: > I'm able to reproduce a lockdep splat with config options: > CONFIG_PROVE_LOCKING=y, > CONFIG_DEBUG_LOCK_ALLOC=y and >

Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

Peter, Ingo or Thomas, Can you queue this up? Or would you prefer that I take it? -- Steve On Tue, 1 May 2018 18:44:39 -0700 Joel Fernandes wrote: > I'm able to reproduce a lockdep splat with config options: > CONFIG_PROVE_LOCKING=y, > CONFIG_DEBUG_LOCK_ALLOC=y and >

[PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

I'm able to reproduce a lockdep splat with config options: CONFIG_PROVE_LOCKING=y, CONFIG_DEBUG_LOCK_ALLOC=y and CONFIG_PREEMPTIRQ_EVENTS=y $ echo 1 > /d/tracing/events/preemptirq/preempt_enable/enable --- [ 26.112609] DEBUG_LOCKS_WARN_ON(current->softirqs_enabled) [ 26.112636] WARNING: CPU:

[PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

I'm able to reproduce a lockdep splat with config options: CONFIG_PROVE_LOCKING=y, CONFIG_DEBUG_LOCK_ALLOC=y and CONFIG_PREEMPTIRQ_EVENTS=y $ echo 1 > /d/tracing/events/preemptirq/preempt_enable/enable --- [ 26.112609] DEBUG_LOCKS_WARN_ON(current->softirqs_enabled) [ 26.112636] WARNING: CPU:

Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

On Thu, 26 Apr 2018 21:11:00 -0700 Joel Fernandes wrote: > I'm able to reproduce a lockdep splat when CONFIG_PROVE_LOCKING=y and > CONFIG_PREEMPTIRQ_EVENTS=y. > > $ echo 1 > /d/tracing/events/preemptirq/preempt_enable/enable > --- > [ 26.112609]

Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

On Thu, 26 Apr 2018 21:11:00 -0700 Joel Fernandes wrote: > I'm able to reproduce a lockdep splat when CONFIG_PROVE_LOCKING=y and > CONFIG_PREEMPTIRQ_EVENTS=y. > > $ echo 1 > /d/tracing/events/preemptirq/preempt_enable/enable > --- > [ 26.112609] DEBUG_LOCKS_WARN_ON(current->softirqs_enabled)

Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

On Mon, 30 Apr 2018 17:01:04 + Joel Fernandes wrote: Tried 4.17-rc3 and see it too. Could be difference in configs? Also, the > environment is a Qemu system with single CPU 1GB memory. Attached is the > config. > > I think when I had multiple CPUs it was harder to trigger

Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

On Mon, 30 Apr 2018 17:01:04 + Joel Fernandes wrote: Tried 4.17-rc3 and see it too. Could be difference in configs? Also, the > environment is a Qemu system with single CPU 1GB memory. Attached is the > config. > > I think when I had multiple CPUs it was harder to trigger it, but can't >

Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

On Mon, Apr 30, 2018 at 9:38 AM Steven Rostedt wrote: > On Thu, 26 Apr 2018 21:11:00 -0700 > Joel Fernandes wrote: > > I'm able to reproduce a lockdep splat when CONFIG_PROVE_LOCKING=y and > > CONFIG_PREEMPTIRQ_EVENTS=y. > > > > $ echo 1 >

Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

On Mon, Apr 30, 2018 at 9:38 AM Steven Rostedt wrote: > On Thu, 26 Apr 2018 21:11:00 -0700 > Joel Fernandes wrote: > > I'm able to reproduce a lockdep splat when CONFIG_PROVE_LOCKING=y and > > CONFIG_PREEMPTIRQ_EVENTS=y. > > > > $ echo 1 > /d/tracing/events/preemptirq/preempt_enable/enable > >

Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

On Thu, 26 Apr 2018 21:11:00 -0700 Joel Fernandes wrote: > I'm able to reproduce a lockdep splat when CONFIG_PROVE_LOCKING=y and > CONFIG_PREEMPTIRQ_EVENTS=y. > > $ echo 1 > /d/tracing/events/preemptirq/preempt_enable/enable > --- > [ 26.112609]

Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

On Thu, 26 Apr 2018 21:11:00 -0700 Joel Fernandes wrote: > I'm able to reproduce a lockdep splat when CONFIG_PROVE_LOCKING=y and > CONFIG_PREEMPTIRQ_EVENTS=y. > > $ echo 1 > /d/tracing/events/preemptirq/preempt_enable/enable > --- > [ 26.112609] DEBUG_LOCKS_WARN_ON(current->softirqs_enabled)

[PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

I'm able to reproduce a lockdep splat when CONFIG_PROVE_LOCKING=y and CONFIG_PREEMPTIRQ_EVENTS=y. $ echo 1 > /d/tracing/events/preemptirq/preempt_enable/enable --- [ 26.112609] DEBUG_LOCKS_WARN_ON(current->softirqs_enabled) [ 26.112636] WARNING: CPU: 0 PID: 118 at

[PATCH] softirq: reorder trace_softirqs_on to prevent lockdep splat

I'm able to reproduce a lockdep splat when CONFIG_PROVE_LOCKING=y and CONFIG_PREEMPTIRQ_EVENTS=y. $ echo 1 > /d/tracing/events/preemptirq/preempt_enable/enable --- [ 26.112609] DEBUG_LOCKS_WARN_ON(current->softirqs_enabled) [ 26.112636] WARNING: CPU: 0 PID: 118 at