Re: [PATCH] solos-pci: don't call vcc->pop() after pclose()

2012-11-29 Thread Krzysztof Mazur
On Thu, Nov 29, 2012 at 02:42:17PM +, David Woodhouse wrote: > On Thu, 2012-11-29 at 14:20 +0100, Krzysztof Mazur wrote: > > if (card->tx_skb[port] == skb) { > > skb_get(skb); > > solos_pop(SKB_CB(skb)->vcc, skb); > >

Re: [PATCH] solos-pci: don't call vcc->pop() after pclose()

2012-11-29 Thread David Woodhouse
On Thu, 2012-11-29 at 14:20 +0100, Krzysztof Mazur wrote: > if (card->tx_skb[port] == skb) { > skb_get(skb); > solos_pop(SKB_CB(skb)->vcc, skb); > SKB_CB(skb)->vcc = NULL; Um... yes, that would probably work. B

Re: [PATCH] solos-pci: don't call vcc->pop() after pclose()

2012-11-29 Thread chas williams - CONTRACTOR
On Thu, 29 Nov 2012 13:43:44 +0100 Krzysztof Mazur wrote: > Removing packets from tx_queue is not needed. We can transmit packets > also after close. We just can't call vcc->pop() after close, > so we can just set SKB_CB(skb)->vcc of such packets to NULL so fpga_tx() > won't call vcc->pop(). i d

Re: [PATCH] solos-pci: don't call vcc->pop() after pclose()

2012-11-29 Thread Krzysztof Mazur
On Thu, Nov 29, 2012 at 12:57:17PM +, David Woodhouse wrote: > On Thu, 2012-11-29 at 13:43 +0100, Krzysztof Mazur wrote: > > > > Removing packets from tx_queue is not needed. We can transmit packets > > also after close. We just can't call vcc->pop() after close, > > so we can just set SKB_CB(

Re: [PATCH] solos-pci: don't call vcc->pop() after pclose()

2012-11-29 Thread David Woodhouse
On Thu, 2012-11-29 at 13:43 +0100, Krzysztof Mazur wrote: > > Removing packets from tx_queue is not needed. We can transmit packets > also after close. We just can't call vcc->pop() after close, > so we can just set SKB_CB(skb)->vcc of such packets to NULL so > fpga_tx() won't call vcc->pop(). Yo

[PATCH] solos-pci: don't call vcc->pop() after pclose()

2012-11-29 Thread Krzysztof Mazur
t; *currently* being DMA'd, and we'd still need to wait for that one. Removing packets from tx_queue is not needed. We can transmit packets also after close. We just can't call vcc->pop() after close, so we can just set SKB_CB(skb)->vcc of such packets to NULL so fpga_tx() won&