Re: [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe

2018-04-13 Thread Mark Brown
On Fri, Apr 13, 2018 at 06:54:15PM +0800, Jia-Ju Bai wrote: > I looked at previous related patches, and find the subject should be "ASoC: > Intel: " > I will follow it in my future patches. Right, that's it for these thanks. > Do I need to send V2 patches? No, it's OK - I already applied

Re: [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe

2018-04-13 Thread Mark Brown
On Fri, Apr 13, 2018 at 06:54:15PM +0800, Jia-Ju Bai wrote: > I looked at previous related patches, and find the subject should be "ASoC: > Intel: " > I will follow it in my future patches. Right, that's it for these thanks. > Do I need to send V2 patches? No, it's OK - I already applied

Re: [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe

2018-04-13 Thread Jia-Ju Bai
On 2018/4/13 18:41, Mark Brown wrote: On Mon, Apr 09, 2018 at 06:46:21PM +0800, Jia-Ju Bai wrote: broxton_audio_probe() is never called in atomic context. This function is only set as ".probe" in "struct platform_driver". Please submit patches using subject lines reflecting the style for the

Re: [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe

2018-04-13 Thread Jia-Ju Bai
On 2018/4/13 18:41, Mark Brown wrote: On Mon, Apr 09, 2018 at 06:46:21PM +0800, Jia-Ju Bai wrote: broxton_audio_probe() is never called in atomic context. This function is only set as ".probe" in "struct platform_driver". Please submit patches using subject lines reflecting the style for the

Re: [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe

2018-04-13 Thread Mark Brown
On Mon, Apr 09, 2018 at 06:46:21PM +0800, Jia-Ju Bai wrote: > broxton_audio_probe() is never called in atomic context. > This function is only set as ".probe" in "struct platform_driver". Please submit patches using subject lines reflecting the style for the subsystem. This makes it easier for

Re: [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe

2018-04-13 Thread Mark Brown
On Mon, Apr 09, 2018 at 06:46:21PM +0800, Jia-Ju Bai wrote: > broxton_audio_probe() is never called in atomic context. > This function is only set as ".probe" in "struct platform_driver". Please submit patches using subject lines reflecting the style for the subsystem. This makes it easier for

Re: [alsa-devel] [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe

2018-04-10 Thread Vinod Koul
On Mon, Apr 09, 2018 at 09:39:06PM +0200, Takashi Iwai wrote: > On Mon, 09 Apr 2018 20:57:43 +0200, > Pierre-Louis Bossart wrote: > > > > On 4/9/18 5:46 AM, Jia-Ju Bai wrote: > > > broxton_audio_probe() is never called in atomic context. > > > This function is only set as ".probe" in "struct

Re: [alsa-devel] [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe

2018-04-10 Thread Vinod Koul
On Mon, Apr 09, 2018 at 09:39:06PM +0200, Takashi Iwai wrote: > On Mon, 09 Apr 2018 20:57:43 +0200, > Pierre-Louis Bossart wrote: > > > > On 4/9/18 5:46 AM, Jia-Ju Bai wrote: > > > broxton_audio_probe() is never called in atomic context. > > > This function is only set as ".probe" in "struct

Re: [alsa-devel] [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe

2018-04-10 Thread Mark Brown
On Mon, Apr 09, 2018 at 09:39:06PM +0200, Takashi Iwai wrote: > It must be sleepable context as it's a standard platform driver probe > callback. > And now looking at grep output, only sound/soc/intel contains so many > calls with GFP_ATOMIC. I bet that almost all can be done with > GFP_KERNEL,

Re: [alsa-devel] [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe

2018-04-10 Thread Mark Brown
On Mon, Apr 09, 2018 at 09:39:06PM +0200, Takashi Iwai wrote: > It must be sleepable context as it's a standard platform driver probe > callback. > And now looking at grep output, only sound/soc/intel contains so many > calls with GFP_ATOMIC. I bet that almost all can be done with > GFP_KERNEL,

Re: [alsa-devel] [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe

2018-04-09 Thread Takashi Iwai
On Mon, 09 Apr 2018 20:57:43 +0200, Pierre-Louis Bossart wrote: > > On 4/9/18 5:46 AM, Jia-Ju Bai wrote: > > broxton_audio_probe() is never called in atomic context. > > This function is only set as ".probe" in "struct platform_driver". > > > > Despite never getting called from atomic context, >

Re: [alsa-devel] [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe

2018-04-09 Thread Takashi Iwai
On Mon, 09 Apr 2018 20:57:43 +0200, Pierre-Louis Bossart wrote: > > On 4/9/18 5:46 AM, Jia-Ju Bai wrote: > > broxton_audio_probe() is never called in atomic context. > > This function is only set as ".probe" in "struct platform_driver". > > > > Despite never getting called from atomic context, >

Re: [alsa-devel] [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe

2018-04-09 Thread Pierre-Louis Bossart
On 4/9/18 5:46 AM, Jia-Ju Bai wrote: broxton_audio_probe() is never called in atomic context. This function is only set as ".probe" in "struct platform_driver". Despite never getting called from atomic context, broxton_audio_probe() calls devm_kzalloc() with GFP_ATOMIC, which waits busily for

Re: [alsa-devel] [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe

2018-04-09 Thread Pierre-Louis Bossart
On 4/9/18 5:46 AM, Jia-Ju Bai wrote: broxton_audio_probe() is never called in atomic context. This function is only set as ".probe" in "struct platform_driver". Despite never getting called from atomic context, broxton_audio_probe() calls devm_kzalloc() with GFP_ATOMIC, which waits busily for

[PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe

2018-04-09 Thread Jia-Ju Bai
broxton_audio_probe() is never called in atomic context. This function is only set as ".probe" in "struct platform_driver". Despite never getting called from atomic context, broxton_audio_probe() calls devm_kzalloc() with GFP_ATOMIC, which waits busily for allocation. GFP_ATOMIC is not necessary

[PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe

2018-04-09 Thread Jia-Ju Bai
broxton_audio_probe() is never called in atomic context. This function is only set as ".probe" in "struct platform_driver". Despite never getting called from atomic context, broxton_audio_probe() calls devm_kzalloc() with GFP_ATOMIC, which waits busily for allocation. GFP_ATOMIC is not necessary