Re: [PATCH] sound: usb: quirks: Replace mdelay() with msleep() and usleep_range()

2018-07-27 Thread Takashi Iwai
On Fri, 27 Jul 2018 10:55:28 +0200, Jia-Ju Bai wrote: > > snd_usb_select_mode_quirk(), snd_usb_set_interface_quirk() and > snd_usb_ctl_msg_quirk() are never called in atomic context. > They call mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep() and

Re: [PATCH] sound: usb: quirks: Replace mdelay() with msleep() and usleep_range()

2018-07-27 Thread Takashi Iwai
On Fri, 27 Jul 2018 10:55:28 +0200, Jia-Ju Bai wrote: > > snd_usb_select_mode_quirk(), snd_usb_set_interface_quirk() and > snd_usb_ctl_msg_quirk() are never called in atomic context. > They call mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep() and

[PATCH] sound: usb: quirks: Replace mdelay() with msleep() and usleep_range()

2018-07-27 Thread Jia-Ju Bai
snd_usb_select_mode_quirk(), snd_usb_set_interface_quirk() and snd_usb_ctl_msg_quirk() are never called in atomic context. They call mdelay() to busily wait, which is not necessary. mdelay() can be replaced with msleep() and usleep_range(). This is found by a static analysis tool named DCNS

[PATCH] sound: usb: quirks: Replace mdelay() with msleep() and usleep_range()

2018-07-27 Thread Jia-Ju Bai
snd_usb_select_mode_quirk(), snd_usb_set_interface_quirk() and snd_usb_ctl_msg_quirk() are never called in atomic context. They call mdelay() to busily wait, which is not necessary. mdelay() can be replaced with msleep() and usleep_range(). This is found by a static analysis tool named DCNS