Re: [PATCH] soundwire: fix error handling

2020-09-01 Thread Nick Desaulniers
On Tue, Sep 1, 2020 at 4:02 AM Vinod Koul wrote: > > Hello Tom, > > On 29-08-20, 08:35, t...@redhat.com wrote: > > From: Tom Rix > > > > clang static analysis flags this problem > > > > stream.c:844:9: warning: Use of memory after > > it is freed > > kfree(bus->defer_msg.msg->buf); > >

Re: [PATCH] soundwire: fix error handling

2020-09-01 Thread Vinod Koul
Hello Tom, On 29-08-20, 08:35, t...@redhat.com wrote: > From: Tom Rix > > clang static analysis flags this problem > > stream.c:844:9: warning: Use of memory after > it is freed > kfree(bus->defer_msg.msg->buf); > ^~~ > > This happens in an error

Re: [PATCH] soundwire: fix error handling

2020-08-31 Thread Pierre-Louis Bossart
On 8/31/20 12:47 PM, Nick Desaulniers wrote: On Sat, Aug 29, 2020 at 8:35 AM wrote: From: Tom Rix clang static analysis flags this problem stream.c:844:9: warning: Use of memory after it is freed kfree(bus->defer_msg.msg->buf); ^~~ This

Re: [PATCH] soundwire: fix error handling

2020-08-31 Thread Tom Rix
On 8/31/20 11:39 AM, Nick Desaulniers wrote: > On Mon, Aug 31, 2020 at 11:20 AM Tom Rix wrote: >> >> On 8/31/20 10:48 AM, Nick Desaulniers wrote: >>> On Mon, Aug 31, 2020 at 10:47 AM Nick Desaulniers >>> wrote: On Sat, Aug 29, 2020 at 8:35 AM wrote: > From: Tom Rix > > clang

Re: [PATCH] soundwire: fix error handling

2020-08-31 Thread Nick Desaulniers
On Mon, Aug 31, 2020 at 11:20 AM Tom Rix wrote: > > > On 8/31/20 10:48 AM, Nick Desaulniers wrote: > > On Mon, Aug 31, 2020 at 10:47 AM Nick Desaulniers > > wrote: > >> On Sat, Aug 29, 2020 at 8:35 AM wrote: > >>> From: Tom Rix > >>> > >>> clang static analysis flags this problem > > Also,

Re: [PATCH] soundwire: fix error handling

2020-08-31 Thread Tom Rix
On 8/31/20 10:48 AM, Nick Desaulniers wrote: > On Mon, Aug 31, 2020 at 10:47 AM Nick Desaulniers > wrote: >> On Sat, Aug 29, 2020 at 8:35 AM wrote: >>> From: Tom Rix >>> >>> clang static analysis flags this problem > Also, Tom, please use ./scripts/get_maintainer.pl on your patches to > CC

Re: [PATCH] soundwire: fix error handling

2020-08-31 Thread Nick Desaulniers
On Mon, Aug 31, 2020 at 10:47 AM Nick Desaulniers wrote: > > On Sat, Aug 29, 2020 at 8:35 AM wrote: > > > > From: Tom Rix > > > > clang static analysis flags this problem Also, Tom, please use ./scripts/get_maintainer.pl on your patches to CC our mailing list;

Re: [PATCH] soundwire: fix error handling

2020-08-31 Thread Nick Desaulniers
On Sat, Aug 29, 2020 at 8:35 AM wrote: > > From: Tom Rix > > clang static analysis flags this problem > > stream.c:844:9: warning: Use of memory after > it is freed > kfree(bus->defer_msg.msg->buf); > ^~~ > > This happens in an error handler cleaning

[PATCH] soundwire: fix error handling

2020-08-29 Thread trix
From: Tom Rix clang static analysis flags this problem stream.c:844:9: warning: Use of memory after it is freed kfree(bus->defer_msg.msg->buf); ^~~ This happens in an error handler cleaning up memory allocated for elements in a list.