Re: [alsa-devel] [PATCH] soundwire: fix pm_runtime_get_sync return code checks

2019-04-14 Thread Vinod Koul
On 08-04-19, 12:43, Pierre-Louis Bossart wrote: > > > On 4/8/19 2:12 AM, Jan Kotas wrote: > > > > > > > On 5 Apr 2019, at 17:04, Pierre-Louis Bossart > > > wrote: > > > > > > On 4/5/19 2:26 AM, Jan Kotas wrote: > > > > > > > > ret = pm_runtime_get_sync(slave->bus->dev); > > > > -

Re: [alsa-devel] [PATCH] soundwire: fix pm_runtime_get_sync return code checks

2019-04-08 Thread Pierre-Louis Bossart
On 4/8/19 2:12 AM, Jan Kotas wrote: On 5 Apr 2019, at 17:04, Pierre-Louis Bossart wrote: On 4/5/19 2:26 AM, Jan Kotas wrote: ret = pm_runtime_get_sync(slave->bus->dev); - if (ret < 0) + if (ret < 0 && ret != -EACCES) There was a patch submitted on 3/28 by Srinivas

Re: [PATCH] soundwire: fix pm_runtime_get_sync return code checks

2019-04-08 Thread Jan Kotas
> On 5 Apr 2019, at 17:04, Pierre-Louis Bossart > wrote: > > On 4/5/19 2:26 AM, Jan Kotas wrote: >> >> >> ret = pm_runtime_get_sync(slave->bus->dev); >> -if (ret < 0) >> +if (ret < 0 && ret != -EACCES) >> > There was a patch submitted on 3/28 by Srinivas Kandagatla who

[PATCH] soundwire: fix pm_runtime_get_sync return code checks

2019-04-05 Thread Jan Kotas
When PM is disabled it returns -EACCES, which is currently threated as an error, and prevents accessing the slave's registers. This patch ignores the -EACCES return value from pm_runtime_get_sync() to let the SoundWire work in systems without runtime PM. Signed-off-by: Jan Kotas ---