Re: [PATCH] soundwire: intel_init: test link->cdns

2021-04-01 Thread Pierre-Louis Bossart
On 4/1/21 2:21 AM, Vinod Koul wrote: On 31-03-21, 09:02, Bard Liao wrote: intel_link_probe() could return error and dev_get_drvdata() will return null in such case. So we have to test link->cdns after link->cdns = dev_get_drvdata(>auxdev.dev); Otherwise, we will meet the "kernel NULL pointer

Re: [PATCH] soundwire: intel_init: test link->cdns

2021-04-01 Thread Vinod Koul
On 31-03-21, 09:02, Bard Liao wrote: > intel_link_probe() could return error and dev_get_drvdata() will return > null in such case. So we have to test link->cdns after > link->cdns = dev_get_drvdata(>auxdev.dev); > Otherwise, we will meet the "kernel NULL pointer dereference" error. This fails to

[PATCH] soundwire: intel_init: test link->cdns

2021-03-30 Thread Bard Liao
intel_link_probe() could return error and dev_get_drvdata() will return null in such case. So we have to test link->cdns after link->cdns = dev_get_drvdata(>auxdev.dev); Otherwise, we will meet the "kernel NULL pointer dereference" error. Signed-off-by: Bard Liao Reviewed-by: Ranjani Sridharan